Improve PDF FastWebView performance. This occurs because the manual data...

Improve PDF FastWebView performance. This occurs because the manual data stream load does not get cancelled correctly. This causes the IPC messages for the manual data stream to continue going back and forth. They are ignored
by the plugin anyways.

This fixes http://code.google.com/p/chromium/issues/detail?id=5196. 

Fix is to cancel the manual document load correctly.

Bug=5196
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6486

[jam, 2008-12-06 01:06:49]

lgtm

http://codereview.chromium.org/13198/diff/1/3
File webkit/glue/webplugin_impl.cc (right):

http://codereview.chromium.org/13198/diff/1/3#newcode228
Line 228: set_ignore_response_error(false);
curious, why is this needed?

[ananta, 2008-12-06 01:16:57]

On 2008/12/06 01:06:49, John Abd-El-Malek wrote:
> lgtm
> 
> http://codereview.chromium.org/13198/diff/1/3
> File webkit/glue/webplugin_impl.cc (right):
> 
> http://codereview.chromium.org/13198/diff/1/3#newcode228
> Line 228: set_ignore_response_error(false);
> curious, why is this needed?
When we cancel the original request it results in a call to
WebPluginContainer::didFail, which when received in the plugin process
would close the stream, on which there are pending NPN_RequestRead requests. I
will add a comment in the code to that effect.

Thanks for the review.

-Ananta

[ananta, 2008-12-06 01:19:05]

On 2008/12/06 01:06:49, John Abd-El-Malek wrote:
> lgtm
> 
> http://codereview.chromium.org/13198/diff/1/3
> File webkit/glue/webplugin_impl.cc (right):
> 
> http://codereview.chromium.org/13198/diff/1/3#newcode228
> Line 228: set_ignore_response_error(false);
> curious, why is this needed?
Sorry for rushing the response. Added just in case a manual data stream load is
initiated a second time.

-Ananta