Add static ensure() methods to unmodifiable views.

sdk/lib/collection/maps.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.collection;
 
 /**
  * Base class for implementing a [Map].
  *
  * This class has a basic implementation of all but five of the members of
@@ skipping 190 matching lines @@
   Iterable<V> get values => _map.values;
 }
 
 /**
  * View of a [Map] that disallow modifying the map.
  *
  * A wrapper around a `Map` that forwards all members to the map provided in
  * the constructor, except for operations that modify the map.
  * Modifying operations throw instead.
  */
-class UnmodifiableMapView<K, V> =
-    MapView<K, V> with _UnmodifiableMapMixin<K, V>;
+class UnmodifiableMapView<K, V> extends MapView<K, V>
+    with _UnmodifiableMapMixin<K, V> {
+  /**
+   * Returns a view of [source] that's guaranteed to be unmodifiable.
+   *
+   * If [source] already extends [UnmodifiableMapBase] or [UnmodifiableMapView],
+   * this avoids re-wrapping it.

[Lasse Reichstein Nielsen, 2015/08/27 07:59:04]

Also say that it returns the original object unwrapped.

[nweiz, 2015/08/27 19:25:37]

Done.

+   */
+  static Map ensure(Map source) =>

[Lasse Reichstein Nielsen, 2015/08/27 07:59:04]

Move below constructor, and also don't like name here.

[nweiz, 2015/08/27 19:25:37]

Done.

+      source is _UnmodifiableMapMixin || source is ImmutableMap

[Lasse Reichstein Nielsen, 2015/08/27 07:59:04]

What is ImmutableMap? 
It looks like the VM's const map, but it doesn't exist in dart2js, so it will be
a malformed type (I don't remember if that means the test throws in checked mode
and succeeds in unchecked, or something else).

[nweiz, 2015/08/27 19:25:37]

Yes, this was intended to handle constant maps. I didn't realize it was VM-only,
though. Is there a reason constant Maps don't extend UnmodifiableMapBase but
constant lists do extend UnmodifiableListBase? Is there any other way we can
check for constant-ness?

+          ? source
+          : new UnmodifiableMapView(source);
+
+  UnmodifiableMapView(Map<K, V> map) : super(map);
+}
 
 /**
  * Helper class which implements complex [Map] operations
  * in term of basic ones ([Map.keys], [Map.operator []],
  * [Map.operator []=] and [Map.remove].)  Not all methods are
  * necessary to implement each particular operation.
  */
 class Maps {
   static bool containsValue(Map map, value) {
     for (final v in map.values) {
@@ skipping 121 matching lines @@
       map[keyIterator.current] = valueIterator.current;
       hasNextKey = keyIterator.moveNext();
       hasNextValue = valueIterator.moveNext();
     }
 
     if (hasNextKey || hasNextValue) {
       throw new ArgumentError("Iterables do not have same length.");
     }
   }
 }