Source/core/editing/serializers/StyledMarkupSerializer.cpp - Issue 1319753004: Introduce composed tree version of VisiblePosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/serializers/StyledMarkupSerializer.cpp

Issue 1319753004: Introduce composed tree version of VisiblePosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-09-07T14:06:02 Rebase for VisibleSelectionChangeObserver and PendingSelection::commit Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/serializers/StyledMarkupSerializer.cpp

diff --git a/Source/core/editing/serializers/StyledMarkupSerializer.cpp b/Source/core/editing/serializers/StyledMarkupSerializer.cpp

index 97c25a333e622b84cf9ad2a4990866d8a9c8c725..6e68282cea768a380da3cd2f744153e4ac996326 100644

--- a/Source/core/editing/serializers/StyledMarkupSerializer.cpp

+++ b/Source/core/editing/serializers/StyledMarkupSerializer.cpp

@@ -175,8 +175,8 @@ String StyledMarkupSerializer<Strategy>::createMarkup()

Node* pastEnd = m_end.nodeAsRangePastLastNode();

Node* firstNode = m_start.nodeAsRangeFirstNode();

- VisiblePosition visibleStart = createVisiblePosition(m_start);

- VisiblePosition visibleEnd = createVisiblePosition(m_end);

+ VisiblePosition visibleStart = createVisiblePositionInDOMTree(m_start);

+ VisiblePosition visibleEnd = createVisiblePositionInDOMTree(m_end);

if (shouldAnnotate() && needInterchangeNewlineAfter(visibleStart)) {

markupAccumulator.appendInterchangeNewline();

if (visibleStart.deepEquivalent() == previousPositionOf(visibleEnd).deepEquivalent())

« no previous file with comments | « Source/core/editing/VisibleSelection.h ('k') | Source/core/layout/PendingSelection.cpp » ('j') | no next file with comments »