Introduce composed tree version of VisiblePosition

Source/core/layout/PendingSelection.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 68 matching lines @@
 template <typename Strategy>
 VisibleSelection PendingSelection::calcVisibleSelectionAlgorithm() const
 {
     using PositionType = typename Strategy::PositionType;
 
     PositionType start = Strategy::selectionStart(m_selection);
     PositionType end = Strategy::selectionEnd(m_selection);
     SelectionType selectionType = Strategy::selectionType(m_selection);
     TextAffinity affinity = m_selection.affinity();
 
-    bool paintBlockCursor = m_shouldShowBlockCursor && selectionType == SelectionType::CaretSelection && !isLogicalEndOfLine(createVisiblePosition(end, affinity));
+    bool paintBlockCursor = m_shouldShowBlockCursor && selectionType == SelectionType::CaretSelection && !isLogicalEndOfLine(createVisiblePositionInDOMTree(end, affinity));
     VisibleSelection selection;
     if (enclosingTextFormControl(start.computeContainerNode())) {
         // TODO(yosin) We should use |PositionMoveType::Character| to avoid
         // ending paint at middle of character.
         PositionType endPosition = paintBlockCursor ? nextPositionOf(Strategy::selectionExtent(m_selection), PositionMoveType::CodePoint) : end;
         selection.setWithoutValidation(start, endPosition);
         return selection;
     }
 
-    VisiblePosition visibleStart = createVisiblePosition(start, selectionType == SelectionType::RangeSelection ? TextAffinity::Downstream : affinity);
+    VisiblePosition visibleStart = createVisiblePositionInDOMTree(start, selectionType == SelectionType::RangeSelection ? TextAffinity::Downstream : affinity);
     if (paintBlockCursor) {
-        VisiblePosition visibleExtent = createVisiblePosition(end, affinity);
+        VisiblePosition visibleExtent = createVisiblePositionInDOMTree(end, affinity);
         visibleExtent = nextPositionOf(visibleExtent, CanSkipOverEditingBoundary);
         return VisibleSelection(visibleStart, visibleExtent);
     }
-    VisiblePosition visibleEnd = createVisiblePosition(end, selectionType == SelectionType::RangeSelection ? TextAffinity::Upstream : affinity);
+    VisiblePosition visibleEnd = createVisiblePositionInDOMTree(end, selectionType == SelectionType::RangeSelection ? TextAffinity::Upstream : affinity);
     return VisibleSelection(visibleStart, visibleEnd);
 }
 
 template <typename Strategy>
 void PendingSelection::commitAlgorithm(LayoutView& layoutView)
 {
     using PositionType = typename Strategy::PositionType;
 
     if (!hasPendingSelection())
         return;
@@ skipping 51 matching lines @@
         return commitAlgorithm<VisibleSelection::InComposedTree>(layoutView);
     commitAlgorithm<VisibleSelection::InDOMTree>(layoutView);
 }
 
 DEFINE_TRACE(PendingSelection)
 {
     visitor->trace(m_selection);
 }
 
 } // namespace blink