exclude instance suggestions in static context - fixes #22932

pkg/analysis_server/test/services/completion/optype_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.completion.contributor.dart.optype;
 
 import 'package:analysis_server/src/services/completion/completion_target.dart';
 import 'package:analysis_server/src/services/completion/optype.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/engine.dart';
@@ skipping 25 matching lines @@
         new SourceFactory([AbstractContextTest.SDK_RESOLVER]);
     context.setContents(source, content);
     CompilationUnit unit = resolved
         ? context.resolveCompilationUnit2(source, source)
         : context.parseCompilationUnit(source);
     CompletionTarget completionTarget =
         new CompletionTarget.forOffset(unit, offset);
     visitor = new OpType.forCompletion(completionTarget, offset);
   }
 
-  void assertOpType({bool prefixed: false, bool returnValue: false,
-      bool typeNames: false, bool voidReturn: false, bool statementLabel: false,
-      bool caseLabel: false, bool constructors: false}) {
+  void assertOpType(
+      {bool caseLabel: false,
+      bool constructors: false,
+      bool prefixed: false,
+      bool returnValue: false,
+      bool statementLabel: false,
+      bool staticMethodBody: false,
+      bool typeNames: false,
+      bool voidReturn: false}) {
+    expect(visitor.includeCaseLabelSuggestions, caseLabel, reason: 'caseLabel');
+    expect(visitor.includeConstructorSuggestions, constructors,
+        reason: 'constructors');
     expect(visitor.includeReturnValueSuggestions, returnValue,
         reason: 'returnValue');
+    expect(visitor.includeStatementLabelSuggestions, statementLabel,
+        reason: 'statementLabel');
     expect(visitor.includeTypeNameSuggestions, typeNames, reason: 'typeNames');
     expect(visitor.includeVoidReturnSuggestions, voidReturn,
         reason: 'voidReturn');
-    expect(visitor.includeStatementLabelSuggestions, statementLabel,
-        reason: 'statementLabel');
-    expect(visitor.includeCaseLabelSuggestions, caseLabel, reason: 'caseLabel');
-    expect(visitor.includeConstructorSuggestions, constructors,
-        reason: 'constructors');
+    expect(visitor.inStaticMethodBody, staticMethodBody,
+        reason: 'staticMethodBody');
     expect(visitor.isPrefixed, prefixed, reason: 'prefixed');
   }
 
   test_Annotation() {
     // SimpleIdentifier  Annotation  MethodDeclaration  ClassDeclaration
     addTestSource('class C { @A^ }');
     assertOpType(returnValue: true, typeNames: true);
   }
 
   test_ArgumentList() {
@@ skipping 168 matching lines @@
     addTestSource('class X {a() {var f; {var x;} D^ var r;} void b() { }}');
     assertOpType(returnValue: true, typeNames: true, voidReturn: true);
   }
 
   test_Block_keyword() {
     addTestSource('class C { static C get instance => null; } main() {C.in^}');
     assertOpType(
         prefixed: true, returnValue: true, typeNames: true, voidReturn: true);
   }
 
+  test_Block_static() {
+    addTestSource('class A {static foo() {^}}');
+    assertOpType(
+        returnValue: true,
+        typeNames: true,
+        staticMethodBody: true,
+        voidReturn: true);
+  }
+
   test_Break_after_label() {
     addTestSource('main() { foo: while (true) { break foo ^ ; } }');
     assertOpType(/* No valid completions */);
   }
 
   test_Break_before_label() {
     addTestSource('main() { foo: while (true) { break ^ foo; } }');
     assertOpType(statementLabel: true);
   }
 
@@ skipping 1087 matching lines @@
   bool get isInSystemLibrary => false;
 
   @override
   String get shortName => fullName;
 
   @override
   Source get source => this;
 
   noSuchMethod(Invocation invocation) => super.noSuchMethod(invocation);
 }