exclude instance suggestions in static context - fixes #22932

pkg/analysis_server/lib/src/services/completion/optype.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.dart.optype;
 
 import 'package:analysis_server/src/services/completion/completion_target.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/scanner.dart';
 
 /**
  * An [AstVisitor] for determining whether top level suggestions or invocation
  * suggestions should be made based upon the type of node in which the
  * suggestions were requested.
  */
 class OpType {
-
   /**
    * Indicates whether constructor suggestions should be included.
    */
   bool includeConstructorSuggestions = false;
 
   /**
    * Indicates whether type names should be suggested.
    */
   bool includeTypeNameSuggestions = false;
 
@@ skipping 13 matching lines @@
    * Indicates whether statement labels should be suggested.
    */
   bool includeStatementLabelSuggestions = false;
 
   /**
    * Indicates whether case labels should be suggested.
    */
   bool includeCaseLabelSuggestions = false;
 
   /**
+   * Indicates whether the completion location is in the body of a static method.
+   */
+  bool inStaticMethodBody = false;
+
+  /**
    * Indicates whether the completion target is prefixed.
    */
   bool isPrefixed = false;
 
   /**
    * Determine the suggestions that should be made based upon the given
    * [CompletionTarget] and [offset].
    */
   factory OpType.forCompletion(CompletionTarget target, int offset) {
     OpType optype = new OpType._();
     target.containingNode
         .accept(new _OpTypeAstVisitor(optype, target.entity, offset));
+    var mthDecl =
+        target.containingNode.getAncestor((p) => p is MethodDeclaration);
+    optype.inStaticMethodBody =
+        mthDecl is MethodDeclaration && mthDecl.isStatic;
     return optype;
   }
 
   OpType._();
 
   /**
    * Indicate whether only type names should be suggested
    */
   bool get includeOnlyTypeNameSuggestions => includeTypeNameSuggestions &&
       !includeReturnValueSuggestions &&
       !includeVoidReturnSuggestions;
 }
 
 class _OpTypeAstVisitor extends GeneralizingAstVisitor {
-
   /**
    * The entity (AstNode or Token) which will be replaced or displaced by the
    * added text.
    */
   final Object entity;
 
   /**
    * The offset within the source at which the completion is requested.
    */
   final int offset;
@@ skipping 546 matching lines @@
   void visitVariableDeclarationStatement(VariableDeclarationStatement node) {}
 
   @override
   void visitWhileStatement(WhileStatement node) {
     if (identical(entity, node.condition)) {
       optype.includeReturnValueSuggestions = true;
       optype.includeTypeNameSuggestions = true;
     }
   }
 }