exclude instance suggestions in static context - fixes #22932

pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.dart.local.declaration.visitor;
 
 import 'package:analysis_server/src/services/completion/suggestion_builder.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/scanner.dart';
 
 /**
  * `LocalDeclarationCollector` visits an [AstNode] and its parent recursively
  * along with any declarations in those nodes. Consumers typically call [visit]
  * which catches the exception thrown by [finished()].
  */
 abstract class LocalDeclarationVisitor extends GeneralizingAstVisitor {
-  static final TypeName STACKTRACE_TYPE = new TypeName(new SimpleIdentifier(
-      new StringToken(TokenType.IDENTIFIER, 'StackTrace', 0)), null);
+  static final TypeName STACKTRACE_TYPE = new TypeName(
+      new SimpleIdentifier(
+          new StringToken(TokenType.IDENTIFIER, 'StackTrace', 0)),
+      null);
 
   final int offset;
 
+  /**
+   * `true` if local inherited types should be visited.
+   */
+  bool includeLocalInheritedTypes = true;
+
   LocalDeclarationVisitor(this.offset);
 
   void declaredClass(ClassDeclaration declaration);
 
   void declaredClassTypeAlias(ClassTypeAlias declaration);
 
   void declaredEnum(EnumDeclaration declaration) {}
 
   void declaredField(FieldDeclaration fieldDecl, VariableDeclaration varDecl);
 
@@ skipping 74 matching lines @@
     if (param != null) {
       declaredParam(param, STACKTRACE_TYPE);
     }
     visitNode(node);
   }
 
   @override
   void visitClassDeclaration(ClassDeclaration node) {
     _visitClassDeclarationMembers(node);
     // imported types are handled by the imported reference contributor
-    visitInheritedTypes(node, localDeclaration: (ClassDeclaration classNode) {
-      _visitClassDeclarationMembers(classNode);
-    });
+    if (includeLocalInheritedTypes) {
+      visitInheritedTypes(node, localDeclaration: (ClassDeclaration classNode) {
+        _visitClassDeclarationMembers(classNode);
+      });
+    }
     visitNode(node);
   }
 
   @override
   void visitCompilationUnit(CompilationUnit node) {
     node.declarations.forEach((Declaration declaration) {
       if (declaration is ClassDeclaration) {
         declaredClass(declaration);
       } else if (declaration is EnumDeclaration) {
         declaredEnum(declaration);
@@ skipping 95 matching lines @@
   void visitSwitchStatement(SwitchStatement node) {
     for (SwitchMember member in node.members) {
       for (Label label in member.labels) {
         declaredLabel(label, true);
       }
     }
     visitNode(node);
   }
 
   void _visitClassDeclarationMembers(ClassDeclaration node) {
-    node.members.forEach((ClassMember member) {
+    for (ClassMember member in node.members) {
       if (member is FieldDeclaration) {
         member.fields.variables.forEach((VariableDeclaration varDecl) {
           declaredField(member, varDecl);
         });
       } else if (member is MethodDeclaration) {
         declaredMethod(member);
       }
-    });
+    }
   }
 
   void _visitParamList(FormalParameterList paramList) {
     if (paramList != null) {
       paramList.parameters.forEach((FormalParameter param) {
         NormalFormalParameter normalParam;
         if (param is DefaultFormalParameter) {
           normalParam = param.parameter;
         } else if (param is NormalFormalParameter) {
           normalParam = param;
@@ skipping 11 matching lines @@
       });
     }
   }
 }
 
 /**
  * Internal exception used to indicate that [LocalDeclarationVisitor]
  * should stop visiting.
  */
 class _LocalDeclarationVisitorFinished {}