Mark Clang-based toolchain as such and vice-versa

Mark Clang-based toolchain as such and vice-versa

GN build configuration uses the is_clang flag to set up compiler flags
for the toolchain and we need to set this flag accordingly to avoid
using Clang-specific flags for GCC and vice-versa.

BUG=https://code.google.com/p/chromium/issues/detail?id=462791
R=bradnelson@chromium.org

Committed: https://chromium.googlesource.com/native_client/src/native_client/+/e861ae41c737fce493bfdd9b6e50614998b21e63

[Petr Hosek, 2015-08-26 15:10:28]

phosek@chromium.org changed reviewers:
+ bradnelson@chromium.org

[bradnelson, 2015-08-26 23:25:38]

lgtm, although not sure what you want to do in light of the gn refactor.

[Petr Hosek, 2015-08-28 15:47:24]

I needed this change while trying to get PPAPI NaCl tests to build in Chrome
which was before the meeting so this change is likely less relevant now.

[Petr Hosek, 2015-08-28 15:48:00]

Committed patchset #1 (id:1) manually as
e861ae41c737fce493bfdd9b6e50614998b21e63 (presubmit successful).

[Dirk Pranke, 2015-08-31 21:27:29]

On 2015/08/28 15:48:00, Petr Hosek wrote:
> Committed patchset #1 (id:1) manually as
> e861ae41c737fce493bfdd9b6e50614998b21e63 (presubmit successful).

This change probably needs to be merged into the chromium //build/toolchain
files now. Do you want to do that, or shall I?

[native-client-reviews_googlegroups.com, 2015-08-31 21:32:42]

I can do that.

On Mon, Aug 31, 2015 at 2:27 PM <dpranke@chromium.org> wrote:

> On 2015/08/28 15:48:00, Petr Hosek wrote:
> > Committed patchset #1 (id:1) manually as
> > e861ae41c737fce493bfdd9b6e50614998b21e63 (presubmit successful).
>
> This change probably needs to be merged into the chromium //build/toolchain
> files now. Do you want to do that, or shall I?
>
> https://codereview.chromium.org/1319733003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[Dirk Pranke, 2015-08-31 21:33:04]

On 2015/08/31 21:27:29, Dirk Pranke wrote:
> On 2015/08/28 15:48:00, Petr Hosek wrote:
> > Committed patchset #1 (id:1) manually as
> > e861ae41c737fce493bfdd9b6e50614998b21e63 (presubmit successful).
> 
> This change probably needs to be merged into the chromium //build/toolchain
> files now. Do you want to do that, or shall I?

Actually, this might not have been needed, since the chromium //build files that
you were using got confused over nacl + clang , but I think the latest version
might be correct.

I am verifying this now.