Add overload support for non-wrapper type vs. primitive type

Source/bindings/scripts/code_generator_v8.pm

 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
 # Copyright (C) 2006 Apple Computer, Inc.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
@@ skipping 2166 matching lines @@
     my $function = shift;
 
     my @andExpression = ();
     push(@andExpression, "info.Length() == $numParameters");
     my $parameterIndex = 0;
     foreach my $parameter (@{$function->parameters}) {
         last if $parameterIndex >= $numParameters;
         my $value = "info[$parameterIndex]";
         my $type = $parameter->type;
 
-        # Only DOMString or wrapper types are checked.
+        # Only DOMString, wrapper types, and (to some degree) non-wrapper types
+        # are checked.
+        #
+        # FIXME: If distinguishing non-primitive type from primitive type,
+        # (e.g., sequence<DOMString> from DOMString or Dictionary from double)
+        # the non-primitive type must appear *first* in the IDL file,
+        # since we're not adding a check to primitive types.
+        # This can be avoided if compute overloads for whole overload set at
+        # once, rather than one method at a time, but that requires a complete
+        # rewrite of this algorithm.
+        #
         # For DOMString with StrictTypeChecking only Null, Undefined and Object
         # are accepted for compatibility. Otherwise, no restrictions are made to
         # match the non-overloaded behavior.
+        #
         # FIXME: Implement WebIDL overload resolution algorithm.
+        # https://code.google.com/p/chromium/issues/detail?id=293561
         if ($type eq "DOMString") {
             if ($parameter->extendedAttributes->{"StrictTypeChecking"}) {
                 push(@andExpression, "isUndefinedOrNull(${value}) || ${value}->IsString() || ${value}->IsObject()");
             }
         } elsif (IsCallbackInterface($parameter->type)) {
-            # For Callbacks only checks if the value is null or object.
+            # For Callbacks only checks if the value is null or function.
             push(@andExpression, "${value}->IsNull() || ${value}->IsFunction()");
         } elsif (GetArrayOrSequenceType($type)) {
             if ($parameter->isNullable) {
                 push(@andExpression, "${value}->IsNull() || ${value}->IsArray()");
             } else {
                 push(@andExpression, "${value}->IsArray()");
             }
         } elsif (IsWrapperType($type)) {
             if ($parameter->isNullable) {
                 push(@andExpression, "${value}->IsNull() || V8${type}::hasInstance($value, info.GetIsolate(), worldType(info.GetIsolate()))");
             } else {
                 push(@andExpression, "V8${type}::hasInstance($value, info.GetIsolate(), worldType(info.GetIsolate()))");
             }
+        } elsif ($nonWrapperTypes{$type}) {
+            # Non-wrapper types are just objects: we don't distinguish type
+            if ($parameter->isNullable) {
+                push(@andExpression, "${value}->IsNull() || ${value}->IsObject()");
+            } else {
+                push(@andExpression, "${value}->IsObject()");
+            }
         }
 
         $parameterIndex++;
     }
     @andExpression = map { "($_)" } @andExpression;
     my $res = "(" . join(" && ", @andExpression) . ")";
     return $res;
 }
 
 # As per Web IDL specification, the length of a function Object is
@@ skipping 4172 matching lines @@
         if ($parameter->type eq "SerializedScriptValue") {
             return 1;
         } elsif (IsIntegerType($parameter->type)) {
             return 1;
         }
     }
     return 0;
 }
 
 1;