Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 131973003: Disable flaky DevToolsBeforeUnloadTest.TestDevToolsOnDevTools on Win. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_sanity_browsertest.cc
diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc
index 0ade4c675c9ab0524b4a83b1f89b5d8ee7df75aa..552cf0560350f663527f42968082317086ea1ed4 100644
--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc
+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc
@@ -669,10 +669,16 @@ IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
CloseDevToolsPopupWindow(devtools_window);
}
+// FLaky on Windows bots: see crbug.com/323847
+#if defined(OS_WIN)
+#define MAYBE_TestDevToolsOnDevTools DISABLED_TestDevToolsOnDevTools
+#else
+#define MAYBE_TestDevToolsOnDevTools TestDevToolsOnDevTools
+#endif
// Tests that BeforeUnload event gets called on devtools that are opened
// on another devtools.
IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
- TestDevToolsOnDevTools) {
+ MAYBE_TestDevToolsOnDevTools) {
ASSERT_TRUE(test_server()->Start());
LoadTestPage(kDebuggerTestPage);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698