Issue 1319703006: When typing phi nodes, weaken union of integer constants to a range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1319703006: When typing phi nodes, weaken union of integer constants to a range. (Closed)

Created:
5 years, 3 months ago by neis

Modified:
5 years ago

Reviewers:
Jarin

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

When typing phi nodes, weaken union of integer constants to a range. R=jarin@chromium.org BUG=

Patch Set 2 : Removed superfluous argument. #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -8 lines)			Patch
M	src/compiler/typer.cc	View	1	2 chunks	+16 lines, -0 lines	1 comment	Download
M	src/types.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/types.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jarin

lgtm with a nit. https://codereview.chromium.org/1319703006/diff/20001/src/compiler/typer.cc File src/compiler/typer.cc (right): https://codereview.chromium.org/1319703006/diff/20001/src/compiler/typer.cc#newcode562 src/compiler/typer.cc:562: Type* myinteger = Type::Intersect(type, integer, ...

5 years, 3 months ago (2015-09-14 08:06:29 UTC) #1

neis

5 years, 3 months ago (2015-09-14 08:25:25 UTC) #2

On 2015/09/14 08:06:29, Jarin wrote:
> lgtm with a nit.
> 
> https://codereview.chromium.org/1319703006/diff/20001/src/compiler/typer.cc
> File src/compiler/typer.cc (right):
> 
>
https://codereview.chromium.org/1319703006/diff/20001/src/compiler/typer.cc#n...
> src/compiler/typer.cc:562: Type* myinteger = Type::Intersect(type, integer,
> zone());
> Could you come up with a better name than myinteger? (E.g.. integer_part or
some
> such.)


For the record: we decided to use a different approach, see issue 1328193003.

Expand Messages | Collapse Messages

Issue 1319703006: When typing phi nodes, weaken union of integer constants to a range. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Removed superfluous argument. #

Messages