Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: sdk/lib/io/secure_server_socket.dart

Issue 1319703002: Breaking Change: merge BoringSSL branch into master (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/iolib_sources.gypi ('k') | sdk/lib/io/secure_socket.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/secure_server_socket.dart
diff --git a/sdk/lib/io/secure_server_socket.dart b/sdk/lib/io/secure_server_socket.dart
index c3ce9cfb49f881e8893bceb7352968c961441192..04ec9e0104054a57327b14c103432b1c9a11ce92 100644
--- a/sdk/lib/io/secure_server_socket.dart
+++ b/sdk/lib/io/secure_server_socket.dart
@@ -45,12 +45,6 @@ class SecureServerSocket extends Stream<SecureSocket> {
*
* [address] must be given as a numeric address, not a host name.
*
- * [certificateName] is the nickname or the distinguished name (DN) of
- * the certificate in the certificate database. It is looked up in the
- * NSS certificate database set by SecureSocket.initialize.
- * If [certificateName] contains "CN=", it is assumed to be a distinguished
- * name. Otherwise, it is looked up as a nickname.
- *
* To request or require that clients authenticate by providing an SSL (TLS)
* client certificate, set the optional parameter [requestClientCertificate]
* or [requireClientCertificate] to true. Requiring a certificate implies
@@ -70,7 +64,7 @@ class SecureServerSocket extends Stream<SecureSocket> {
static Future<SecureServerSocket> bind(
address,
int port,
- String certificateName,
+ SecurityContext context,
{int backlog: 0,
bool v6Only: false,
bool requestClientCertificate: false,
@@ -80,7 +74,7 @@ class SecureServerSocket extends Stream<SecureSocket> {
return RawSecureServerSocket.bind(
address,
port,
- certificateName,
+ context,
backlog: backlog,
v6Only: v6Only,
requestClientCertificate: requestClientCertificate,
@@ -128,21 +122,20 @@ class SecureServerSocket extends Stream<SecureSocket> {
* See [RawSecureSocket] for more info.
*/
class RawSecureServerSocket extends Stream<RawSecureSocket> {
- RawServerSocket _socket;
+ final RawServerSocket _socket;
StreamController<RawSecureSocket> _controller;
StreamSubscription<RawSocket> _subscription;
- final String certificateName;
+ final SecurityContext _context;
final bool requestClientCertificate;
final bool requireClientCertificate;
final List<String> supportedProtocols;
bool _closed = false;
- RawSecureServerSocket._(RawServerSocket serverSocket,
- this.certificateName,
+ RawSecureServerSocket._(this._socket,
+ this._context,
this.requestClientCertificate,
this.requireClientCertificate,
this.supportedProtocols) {
- _socket = serverSocket;
_controller = new StreamController<RawSecureSocket>(
sync: true,
onListen: _onSubscriptionStateChange,
@@ -205,7 +198,7 @@ class RawSecureServerSocket extends Stream<RawSecureSocket> {
static Future<RawSecureServerSocket> bind(
address,
int port,
- String certificateName,
+ SecurityContext context,
{int backlog: 0,
bool v6Only: false,
bool requestClientCertificate: false,
@@ -216,7 +209,7 @@ class RawSecureServerSocket extends Stream<RawSecureSocket> {
address, port, backlog: backlog, v6Only: v6Only, shared: shared)
.then((serverSocket) => new RawSecureServerSocket._(
serverSocket,
- certificateName,
+ context,
requestClientCertificate,
requireClientCertificate,
supportedProtocols));
@@ -263,7 +256,7 @@ class RawSecureServerSocket extends Stream<RawSecureSocket> {
_RawSecureSocket.connect(
connection.address,
remotePort,
- certificateName,
+ context: _context,
is_server: true,
socket: connection,
requestClientCertificate: requestClientCertificate,
« no previous file with comments | « sdk/lib/io/iolib_sources.gypi ('k') | sdk/lib/io/secure_socket.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698