Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 1319673003: Reland of move javaEnabled setting. (Closed)

Created:
5 years, 3 months ago by battre
Modified:
5 years, 3 months ago
Reviewers:
haraken, dcheng
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, Will Harris
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reland of move javaEnabled setting. (patchset #1 id:1 of https://codereview.chromium.org/1318703002/ ) Reason for revert: Relanding because this had no impact. The bug disappeared and re-appeared regardless of this CL. Original issue's description: > Revert of Remove javaEnabled setting. (patchset #1 id:1 of https://codereview.chromium.org/1306403003/ ) > > Reason for revert: > Reverting to see whether this fixes the compilation. > > Original issue's description: > > Remove javaEnabled setting. > > > > As of M45, NPAPI support is (almost) completely gone, so Java will never > > be supported anyway. > > > > BUG=none > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201211 > > TBR=haraken@chromium.org,dcheng@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=none > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201217 TBR=haraken@chromium.org,dcheng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -49 lines) Patch
M LayoutTests/fast/plugins/plugin-placeholder.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/plugins/plugin-placeholder-explicit-size.html View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/Settings.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLAppletElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLAppletElement.cpp View 2 chunks +2 lines, -25 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/plugins/NavigatorPlugins.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/plugins/NavigatorPlugins.cpp View 2 chunks +1 line, -9 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
battre
Created Reland of move javaEnabled setting.
5 years, 3 months ago (2015-08-26 09:10:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319673003/1
5 years, 3 months ago (2015-08-26 09:10:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201218
5 years, 3 months ago (2015-08-26 09:11:15 UTC) #3
haraken
5 years, 3 months ago (2015-08-26 09:12:52 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698