Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1319663007: Update gyp LINK_COMMANDS_AIX to support both 32-bit and 64-bit files. (Closed)

Created:
5 years, 3 months ago by David Edelsohn
Modified:
5 years, 3 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Update gyp LINK_COMMANDS_AIX to support both 32-bit and 64-bit files. * cmd_alink: Add -X32_64 option. * cmd_alink_thin: Add -X32_64 option. BUG= R=thakis@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/cf3170e30578d600b8ec8cd68553cc5e606d42eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pylib/gyp/generator/make.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
cl description should probably say -X32_64 not -X32-64? other than that rs-lgtm, i know nothing ...
5 years, 3 months ago (2015-09-04 17:05:27 UTC) #2
David Edelsohn
On 2015/09/04 17:05:27, Nico (afk Tue-Wed Sep 7-8) wrote: > cl description should probably say ...
5 years, 3 months ago (2015-09-11 13:00:34 UTC) #3
vogelheim
Committed patchset #1 (id:1) manually as cf3170e30578d600b8ec8cd68553cc5e606d42eb (presubmit successful).
5 years, 3 months ago (2015-09-16 08:51:39 UTC) #4
vogelheim
5 years, 3 months ago (2015-09-16 08:55:03 UTC) #5
Message was sent while issue was closed.
On 2015/09/16 08:51:39, vogelheim wrote:
> Committed patchset #1 (id:1) manually as
> cf3170e30578d600b8ec8cd68553cc5e606d42eb (presubmit successful).

Landed. Forgot to add "Patch from ..." in description to give due credit. Really
sorry about that.

Powered by Google App Engine
This is Rietveld 408576698