Web Animations: Don't suppress graphics layer properties when cancelling animations

Web Animations: Don't suppress graphics layer properties when cancelling animations

CompositedDeprecatedPaintLayerMapping contains logic to suppress
redundant changes to layers while composited animations are running. The
order of operations (composted animations are updated after layers)
meant that a compositing update that resulted in the cancelling of compositor
animations would still suppress these values.

BUG=501297
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201214

[dstockwell, 2015-08-26 05:09:44]

dstockwell@chromium.org changed reviewers:
+ alancutter@chromium.org

[dstockwell, 2015-08-26 05:10:45]

The CQ bit was checked by dstockwell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-26 05:10:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1319653002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1319653002/1

[commit-bot: I haz the power, 2015-08-26 06:29:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-26 06:29:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2015-08-26 06:29:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alancutter (OOO until 2018), 2015-08-26 06:29:58]

lgtm

[dstockwell, 2015-08-26 06:51:00]

The CQ bit was checked by dstockwell@chromium.org

[commit-bot: I haz the power, 2015-08-26 06:51:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1319653002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1319653002/1

[commit-bot: I haz the power, 2015-08-26 08:23:39]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201214

[esprehn, 2015-08-26 08:44:27]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2015-08-26 08:44:28]

https://codereview.chromium.org/1319653002/diff/1/Source/core/animation/Anima...
File Source/core/animation/AnimationStack.cpp (right):

https://codereview.chromium.org/1319653002/diff/1/Source/core/animation/Anima...
Source/core/animation/AnimationStack.cpp:78: if (sampledEffect->effect() &&
sampledEffect->effect()->animation()->playing() &&
sampledEffect->effect()->hasActiveAnimationsOnCompositor(property))
Can you explain why this fixes the bug? Your description doesn't really explain
why adding a check for playing() fixes it.

[dstockwell, 2015-08-27 01:53:52]

On 2015/08/26 at 08:44:28, esprehn wrote:
>
https://codereview.chromium.org/1319653002/diff/1/Source/core/animation/Anima...
> File Source/core/animation/AnimationStack.cpp (right):
> 
>
https://codereview.chromium.org/1319653002/diff/1/Source/core/animation/Anima...
> Source/core/animation/AnimationStack.cpp:78: if (sampledEffect->effect() &&
sampledEffect->effect()->animation()->playing() &&
sampledEffect->effect()->hasActiveAnimationsOnCompositor(property))
> Can you explain why this fixes the bug? Your description doesn't really
explain why adding a check for playing() fixes it.

If the animation is not playing, then we should not consider the registered
compositor animations to be active as they will be subsequently cancelled.