Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1319623004: Improve VisibleUnitsTest.localCaretRectOfPosition (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Improve VisibleUnitsTest.localCaretRectOfPosition This patch changes |VisibleUnitsTest.localCaretRectOfPosition| to check results of |localCaretRectOfPosition()| aren't empty for improving detection of regression. This is a follow-up patch for http://crrev.com/1317503002, which introduces composed tree version of | localCaretRectOfPosition()|. BUG=513568 TEST=webkit_unit_tests --gtest_filter=VisibleUnitsTest.localCaretRectOfPosition Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201186

Patch Set 1 : 2015-08-26T10:49:59 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/core/editing/VisibleUnitsTest.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-26 02:07:28 UTC) #2
yoichio
lgtm
5 years, 3 months ago (2015-08-26 02:14:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319623004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319623004/1
5 years, 3 months ago (2015-08-26 02:19:30 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 02:35:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201186

Powered by Google App Engine
This is Rietveld 408576698