Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2295)

Unified Diff: build/android/gn/zip.py

Issue 1319623002: Make building of resource zips and srcjars hermetic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@md5-proguard
Patch Set: rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/gyp/process_resources.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gn/zip.py
diff --git a/build/android/gn/zip.py b/build/android/gn/zip.py
index 5050ea07107d0afdcdfd273728447a614b4b5603..b80e0a1e4c582cb09c3c4dee8152f1b27391b502 100755
--- a/build/android/gn/zip.py
+++ b/build/android/gn/zip.py
@@ -11,16 +11,10 @@ import ast
import optparse
import os
import sys
-import zipfile
sys.path.append(os.path.join(os.path.dirname(__file__), os.pardir, 'gyp'))
from util import build_utils
-def DoZip(inputs, output, base_dir):
- with zipfile.ZipFile(output, 'w') as outfile:
- for f in inputs:
- outfile.write(f, os.path.relpath(f, base_dir))
-
def main():
parser = optparse.OptionParser()
build_utils.AddDepfileOption(parser)
@@ -37,7 +31,7 @@ def main():
output = options.output
base_dir = options.base_dir
- DoZip(inputs, output, base_dir)
+ build_utils.DoZip(inputs, output, base_dir)
if options.depfile:
build_utils.WriteDepfile(
« no previous file with comments | « no previous file | build/android/gyp/process_resources.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698