Issue 1319613002: [DevTools] Refactor WebInspector.EventListener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1319613002: [DevTools] Refactor WebInspector.EventListener (Closed)

Created:
5 years, 3 months ago by kozy

Modified:
5 years, 3 months ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

[DevTools] Refactor WebInspector.EventListener Move logic from cstor for reusing it in future CLs. R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201165

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -38 lines)			Patch
M	LayoutTests/inspector/domdebugger/domdebugger-getEventListeners.html	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/inspector/domdebugger/domdebugger-getEventListeners-expected.txt	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/devtools/front_end/components/EventListenersView.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/sdk/RemoteObject.js	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/sdk/RuntimeModel.js	View	3 chunks	+20 lines, -28 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319613002/1

5 years, 3 months ago (2015-08-25 20:42:12 UTC) #4

commit-bot: I haz the power

5 years, 3 months ago (2015-08-25 22:49:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201165

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages