Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/extension_creator.cc

Issue 13196006: Move path functions from file_util to FilePath object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: git try Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_browsertest.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | webkit/plugins/npapi/plugin_list_posix.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_creator.cc
diff --git a/chrome/browser/extensions/extension_creator.cc b/chrome/browser/extensions/extension_creator.cc
index 988bfb69dd220102425e086b65fc2e38e2c10b46..9ac76e8db2a01ac27db3bb0b8328a960e0454ab5 100644
--- a/chrome/browser/extensions/extension_creator.cc
+++ b/chrome/browser/extensions/extension_creator.cc
@@ -47,8 +47,9 @@ bool ExtensionCreator::InitializeInput(
return false;
}
- base::FilePath absolute_extension_dir = extension_dir;
- if (!file_util::AbsolutePath(&absolute_extension_dir)) {
+ base::FilePath absolute_extension_dir =
+ base::MakeAbsoluteFilePath(extension_dir);
+ if (absolute_extension_dir.empty()) {
error_message_ =
l10n_util::GetStringUTF8(IDS_EXTENSION_CANT_GET_ABSOLUTE_PATH);
return false;
« no previous file with comments | « chrome/browser/extensions/extension_browsertest.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | webkit/plugins/npapi/plugin_list_posix.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698