Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2219)

Unified Diff: base/file_util_unittest.cc

Issue 13196006: Move path functions from file_util to FilePath object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: git try Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/file_util_unittest.cc
diff --git a/base/file_util_unittest.cc b/base/file_util_unittest.cc
index 77dd7ac4f285c3107e9ec2777ff78cfc700886a7..5cfc677ec95081bcd715ab586a5fe5f2e3c941a6 100644
--- a/base/file_util_unittest.cc
+++ b/base/file_util_unittest.cc
@@ -1961,50 +1961,6 @@ TEST_F(FileUtilTest, AppendToFile) {
EXPECT_EQ(L"hellohello", read_content);
}
-TEST_F(FileUtilTest, Contains) {
- FilePath data_dir =
- temp_dir_.path().Append(FILE_PATH_LITERAL("FilePathTest"));
-
- // Create a fresh, empty copy of this directory.
- if (file_util::PathExists(data_dir)) {
- ASSERT_TRUE(file_util::Delete(data_dir, true));
- }
- ASSERT_TRUE(file_util::CreateDirectory(data_dir));
-
- FilePath foo(data_dir.Append(FILE_PATH_LITERAL("foo")));
- FilePath bar(foo.Append(FILE_PATH_LITERAL("bar.txt")));
- FilePath baz(data_dir.Append(FILE_PATH_LITERAL("baz.txt")));
- FilePath foobar(data_dir.Append(FILE_PATH_LITERAL("foobar.txt")));
-
- // Annoyingly, the directories must actually exist in order for realpath(),
- // which Contains() relies on in posix, to work.
- ASSERT_TRUE(file_util::CreateDirectory(foo));
- std::string data("hello");
- ASSERT_TRUE(file_util::WriteFile(bar, data.c_str(), data.length()));
- ASSERT_TRUE(file_util::WriteFile(baz, data.c_str(), data.length()));
- ASSERT_TRUE(file_util::WriteFile(foobar, data.c_str(), data.length()));
-
- EXPECT_TRUE(file_util::ContainsPath(foo, bar));
- EXPECT_FALSE(file_util::ContainsPath(foo, baz));
- EXPECT_FALSE(file_util::ContainsPath(foo, foobar));
- EXPECT_FALSE(file_util::ContainsPath(foo, foo));
-
- // Platform-specific concerns.
- FilePath foo_caps(data_dir.Append(FILE_PATH_LITERAL("FOO")));
-#if defined(OS_WIN)
- EXPECT_TRUE(file_util::ContainsPath(foo,
- foo_caps.Append(FILE_PATH_LITERAL("bar.txt"))));
- EXPECT_TRUE(file_util::ContainsPath(foo,
- FilePath(foo.value() + FILE_PATH_LITERAL("/bar.txt"))));
-#elif defined(OS_MACOSX)
- // We can't really do this test on OS X since the case-sensitivity of the
- // filesystem is configurable.
-#elif defined(OS_POSIX)
- EXPECT_FALSE(file_util::ContainsPath(foo,
- foo_caps.Append(FILE_PATH_LITERAL("bar.txt"))));
-#endif
-}
-
TEST_F(FileUtilTest, TouchFile) {
FilePath data_dir =
temp_dir_.path().Append(FILE_PATH_LITERAL("FilePathTest"));

Powered by Google App Engine
This is Rietveld 408576698