chrome/browser/platform_util_win.cc - Issue 13196006: Move path functions from file_util to FilePath object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/platform_util_win.cc

Issue 13196006: Move path functions from file_util to FilePath object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Try fixes, merge Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/platform_util_win.cc

diff --git a/chrome/browser/platform_util_win.cc b/chrome/browser/platform_util_win.cc

index 4290009d75dc225c468f7a4534d9222d8f2bdac9..f0f6f07db2fc04b7f5c33ab17b2baab81fac3ec0 100644

--- a/chrome/browser/platform_util_win.cc

+++ b/chrome/browser/platform_util_win.cc

@@ -31,9 +31,9 @@ namespace {

void ShowItemInFolderOnFileThread(const base::FilePath& full_path) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

- base::FilePath dir = full_path.DirName();

+ base::FilePath dir = full_path.DirName().AsEndingWithSeparator();

// ParseDisplayName will fail if the directory is "C:", it must be "C:\\".

- if (dir.value() == L"" || !file_util::EnsureEndsWithSeparator(&dir))

+ if (dir.empty())

return;

typedef HRESULT (WINAPI *SHOpenFolderAndSelectItemsFuncPtr)(