chrome/browser/net/url_fixer_upper.cc - Issue 13196006: Move path functions from file_util to FilePath object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/url_fixer_upper.cc

Issue 13196006: Move path functions from file_util to FilePath object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Try fixes, merge Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/url_fixer_upper.cc

diff --git a/chrome/browser/net/url_fixer_upper.cc b/chrome/browser/net/url_fixer_upper.cc

index 1dadc5b44390d5258e903b0362c48361dda8fb88..06650b7a0e2251b878341463e49c6f10b6a4dce7 100644

--- a/chrome/browser/net/url_fixer_upper.cc

+++ b/chrome/browser/net/url_fixer_upper.cc

@@ -103,8 +103,8 @@ void PrepareStringForFileOps(const base::FilePath& text,

// returns false and leaves |full_path| unchanged.

bool ValidPathForFile(const base::FilePath::StringType& text,

base::FilePath* full_path) {

- base::FilePath file_path(text);

- if (!file_util::AbsolutePath(&file_path))

+ base::FilePath file_path = base::FilePath(text).AsAbsolute();

+ if (file_path.empty())

return false;

if (!file_util::PathExists(file_path))