extensions/common/extension_resource_unittest.cc - Issue 13196006: Move path functions from file_util to FilePath object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/extension_resource_unittest.cc

Issue 13196006: Move path functions from file_util to FilePath object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move AsAbsolute back out of FilePath Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/extension_resource_unittest.cc

diff --git a/extensions/common/extension_resource_unittest.cc b/extensions/common/extension_resource_unittest.cc

index b2983eaad74239fac5a38f55cad76e6a3383aed6..8a74d5f73ec4b8bb593c1a3f606834f4020144e5 100644

--- a/extensions/common/extension_resource_unittest.cc

+++ b/extensions/common/extension_resource_unittest.cc

@@ -150,8 +150,8 @@ TEST(ExtensionResourceTest, CreateWithAllResourcesOnDisk) {

base::FilePath expected_path;

// Expect default path only, since fallback logic is disabled.

// See http://crbug.com/27359.

- expected_path = root_resource;

- ASSERT_TRUE(file_util::AbsolutePath(&expected_path));

+ expected_path = root_resource.AsAbsolute();

+ ASSERT_FALSE(expected_path.empty());

EXPECT_EQ(ToLower(expected_path.value()), ToLower(resolved_path.value()));

EXPECT_EQ(ToLower(temp.path().value()),