chrome_frame/test/reliability/page_load_test.cc - Issue 13196006: Move path functions from file_util to FilePath object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/test/reliability/page_load_test.cc

Issue 13196006: Move path functions from file_util to FilePath object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move AsAbsolute back out of FilePath Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome_frame/test/reliability/page_load_test.cc

diff --git a/chrome_frame/test/reliability/page_load_test.cc b/chrome_frame/test/reliability/page_load_test.cc

index 4d67392d68fefb07981e456454cda13d9ba30c66..59212a607c4c2a84b9a4634f8ab61a37d2ee7b8b 100644

--- a/chrome_frame/test/reliability/page_load_test.cc

+++ b/chrome_frame/test/reliability/page_load_test.cc

@@ -587,9 +587,8 @@ void SetPageRange(const CommandLine& parsed_command_line) {

CommandLine v8_command_line(

parsed_command_line.GetSwitchValuePath(switches::kJavaScriptFlags));

if (v8_command_line.HasSwitch(kV8LogFileSwitch)) {

- g_v8_log_path = v8_command_line.GetSwitchValuePath(kV8LogFileSwitch);

- if (!file_util::AbsolutePath(&g_v8_log_path))

- g_v8_log_path = base::FilePath();

+ g_v8_log_path = base::MakeAbsoluteFilePath(

+ v8_command_line.GetSwitchValuePath(kV8LogFileSwitch));

}