Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: chrome/browser/extensions/platform_app_launcher.cc

Issue 13196006: Move path functions from file_util to FilePath object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move AsAbsolute back out of FilePath Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/platform_app_launcher.cc
diff --git a/chrome/browser/extensions/platform_app_launcher.cc b/chrome/browser/extensions/platform_app_launcher.cc
index 6effb607eab8d21df99b3834670d93a92c0a278a..6bc49e6ff4e5b798fb9196770f38bdb7eca49097 100644
--- a/chrome/browser/extensions/platform_app_launcher.cc
+++ b/chrome/browser/extensions/platform_app_launcher.cc
@@ -62,8 +62,10 @@ bool MakePathAbsolute(const base::FilePath& current_directory,
if (file_path->IsAbsolute())
return true;
- if (current_directory.empty())
- return file_util::AbsolutePath(file_path);
+ if (current_directory.empty()) {
+ *file_path = base::MakeAbsoluteFilePath(*file_path);
+ return !file_path->empty();
+ }
if (!current_directory.IsAbsolute())
return false;

Powered by Google App Engine
This is Rietveld 408576698