chrome/browser/extensions/platform_app_launcher.cc - Issue 13196006: Move path functions from file_util to FilePath object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/platform_app_launcher.cc

Issue 13196006: Move path functions from file_util to FilePath object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move AsAbsolute back out of FilePath Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/platform_app_launcher.cc

diff --git a/chrome/browser/extensions/platform_app_launcher.cc b/chrome/browser/extensions/platform_app_launcher.cc

index 6effb607eab8d21df99b3834670d93a92c0a278a..6bc49e6ff4e5b798fb9196770f38bdb7eca49097 100644

--- a/chrome/browser/extensions/platform_app_launcher.cc

+++ b/chrome/browser/extensions/platform_app_launcher.cc

@@ -62,8 +62,10 @@ bool MakePathAbsolute(const base::FilePath& current_directory,

if (file_path->IsAbsolute())

return true;

- if (current_directory.empty())

- return file_util::AbsolutePath(file_path);

+ if (current_directory.empty()) {

+ *file_path = base::MakeAbsoluteFilePath(*file_path);

+ return !file_path->empty();

+ }

if (!current_directory.IsAbsolute())

return false;