chrome/browser/extensions/extension_creator.cc - Issue 13196006: Move path functions from file_util to FilePath object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_creator.cc

Issue 13196006: Move path functions from file_util to FilePath object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move AsAbsolute back out of FilePath Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_creator.cc

diff --git a/chrome/browser/extensions/extension_creator.cc b/chrome/browser/extensions/extension_creator.cc

index 8842e0d8d33f8763d099a05dede903c0c99ed400..46a774b1917a1e37a7c91e76e823a93d8f992733 100644

--- a/chrome/browser/extensions/extension_creator.cc

+++ b/chrome/browser/extensions/extension_creator.cc

@@ -47,8 +47,9 @@ bool ExtensionCreator::InitializeInput(

return false;

}

- base::FilePath absolute_extension_dir = extension_dir;

- if (!file_util::AbsolutePath(&absolute_extension_dir)) {

+ base::FilePath absolute_extension_dir =

+ base::MakeAbsoluteFilePath(extension_dir);

+ if (absolute_extension_dir.empty()) {

error_message_ =

l10n_util::GetStringUTF8(IDS_EXTENSION_CANT_GET_ABSOLUTE_PATH);

return false;