chrome/browser/extensions/component_loader.cc - Issue 13196006: Move path functions from file_util to FilePath object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/component_loader.cc

Issue 13196006: Move path functions from file_util to FilePath object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move AsAbsolute back out of FilePath Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/component_loader.cc

diff --git a/chrome/browser/extensions/component_loader.cc b/chrome/browser/extensions/component_loader.cc

index 5749f13cd53d7361f8eb41757674bb8eddb7ae8d..8d94cfae51aff50a42f4b668a1f48a219c14c120 100644

--- a/chrome/browser/extensions/component_loader.cc

+++ b/chrome/browser/extensions/component_loader.cc

@@ -149,8 +149,7 @@ std::string ComponentLoader::Add(const DictionaryValue* parsed_manifest,

}

std::string ComponentLoader::AddOrReplace(const base::FilePath& path) {

- base::FilePath absolute_path = path;

- file_util::AbsolutePath(&absolute_path);

+ base::FilePath absolute_path = base::MakeAbsoluteFilePath(path);

std::string error;

scoped_ptr<DictionaryValue> manifest(

extension_file_util::LoadManifest(absolute_path, &error));