Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/common/extension_resource_unittest.cc

Issue 13196006: Move path functions from file_util to FilePath object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/gpu/gpu_pixel_browsertest.cc ('K') | « extensions/common/extension_resource.cc ('k') | net/url_request/file_protocol_handler.cc » ('j') | webkit/support/webkit_support.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/extension_resource_unittest.cc
diff --git a/extensions/common/extension_resource_unittest.cc b/extensions/common/extension_resource_unittest.cc
index b2983eaad74239fac5a38f55cad76e6a3383aed6..fa398839e99c2cd2b50b55a46a83fdd679309303 100644
--- a/extensions/common/extension_resource_unittest.cc
+++ b/extensions/common/extension_resource_unittest.cc
@@ -150,8 +150,7 @@ TEST(ExtensionResourceTest, CreateWithAllResourcesOnDisk) {
base::FilePath expected_path;
// Expect default path only, since fallback logic is disabled.
// See http://crbug.com/27359.
- expected_path = root_resource;
- ASSERT_TRUE(file_util::AbsolutePath(&expected_path));
+ expected_path = root_resource.AsAbsolute();
brettw 2013/03/30 04:19:38 Fixme
EXPECT_EQ(ToLower(expected_path.value()), ToLower(resolved_path.value()));
EXPECT_EQ(ToLower(temp.path().value()),
« chrome/test/gpu/gpu_pixel_browsertest.cc ('K') | « extensions/common/extension_resource.cc ('k') | net/url_request/file_protocol_handler.cc » ('j') | webkit/support/webkit_support.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698