Move path functions from file_util to FilePath object.

webkit/plugins/npapi/plugin_list_posix.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/npapi/plugin_list.h"
 
 #include <algorithm>
 
 #include "base/cpu.h"
 #include "base/file_util.h"
@@ skipping 198 matching lines @@
                                        false,  // not recursive
                                        file_util::FileEnumerator::FILES);
   for (base::FilePath path = enumerator.Next(); !path.value().empty();
        path = enumerator.Next()) {
     // Skip over Mozilla .xpt files.
     if (path.MatchesExtension(FILE_PATH_LITERAL(".xpt")))
       continue;
 
     // Java doesn't like being loaded through a symlink, since it uses
     // its path to find dependent data files.
-    // file_util::AbsolutePath calls through to realpath(), which resolves
+    // MakeAbsoluteFilePath calls through to realpath(), which resolves
     // symlinks.
-    base::FilePath orig_path = path;
-    file_util::AbsolutePath(&path);
+    base::FilePath orig_path = base::MakeAbsoluteFilePath(path);

[Steve Block, 2013/05/07 06:46:28]

Shouldn't this be 'path = ...', and orig_path should be left as it was?

     LOG_IF(ERROR, PluginList::DebugPluginLoading())
         << "Resolved " << orig_path.value() << " -> " << path.value();
 
     if (std::find(plugins->begin(), plugins->end(), path) != plugins->end()) {
       LOG_IF(ERROR, PluginList::DebugPluginLoading())
           << "Skipping duplicate instance of " << path.value();
       continue;
     }
 
     if (IsBlacklistedPlugin(path)) {
@@ skipping 61 matching lines @@
 
   // TODO(evanm): prefer the newest version of flash, etc. here?
 
   VLOG_IF(1, PluginList::DebugPluginLoading()) << "Using " << info.path.value();
 
   return true;
 }
 
 }  // namespace npapi
 }  // namespace webkit