Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: chrome_frame/test/reliability/page_load_test.cc

Issue 13196006: Move path functions from file_util to FilePath object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: git try Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file provides reliablity tests which run for ChromeFrame. 5 // This file provides reliablity tests which run for ChromeFrame.
6 // 6 //
7 // Usage: 7 // Usage:
8 // <reliability test exe> --list=file --startline=start --endline=end [...] 8 // <reliability test exe> --list=file --startline=start --endline=end [...]
9 // Upon invocation, it visits each of the URLs on line numbers between start 9 // Upon invocation, it visits each of the URLs on line numbers between start
10 // and end, inclusive, stored in the input file. The line number starts from 1. 10 // and end, inclusive, stored in the input file. The line number starts from 1.
(...skipping 569 matching lines...) Expand 10 before | Expand all | Expand 10 after
580 g_chrome_log_path = logging::GetLogFileName(); 580 g_chrome_log_path = logging::GetLogFileName();
581 // We won't get v8 log unless --no-sandbox is specified. 581 // We won't get v8 log unless --no-sandbox is specified.
582 if (parsed_command_line.HasSwitch(switches::kNoSandbox)) { 582 if (parsed_command_line.HasSwitch(switches::kNoSandbox)) {
583 PathService::Get(base::DIR_CURRENT, &g_v8_log_path); 583 PathService::Get(base::DIR_CURRENT, &g_v8_log_path);
584 g_v8_log_path = g_v8_log_path.AppendASCII(kV8LogFileDefaultName); 584 g_v8_log_path = g_v8_log_path.AppendASCII(kV8LogFileDefaultName);
585 // The command line switch may override the default v8 log path. 585 // The command line switch may override the default v8 log path.
586 if (parsed_command_line.HasSwitch(switches::kJavaScriptFlags)) { 586 if (parsed_command_line.HasSwitch(switches::kJavaScriptFlags)) {
587 CommandLine v8_command_line( 587 CommandLine v8_command_line(
588 parsed_command_line.GetSwitchValuePath(switches::kJavaScriptFlags)); 588 parsed_command_line.GetSwitchValuePath(switches::kJavaScriptFlags));
589 if (v8_command_line.HasSwitch(kV8LogFileSwitch)) { 589 if (v8_command_line.HasSwitch(kV8LogFileSwitch)) {
590 g_v8_log_path = v8_command_line.GetSwitchValuePath(kV8LogFileSwitch); 590 g_v8_log_path = base::MakeAbsoluteFilePath(
591 if (!file_util::AbsolutePath(&g_v8_log_path)) 591 v8_command_line.GetSwitchValuePath(kV8LogFileSwitch));
592 g_v8_log_path = base::FilePath();
593 } 592 }
594 } 593 }
595 } 594 }
596 } 595 }
597 } 596 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698