Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 13196006: Move path functions from file_util to FilePath object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: git try Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_service_unittest.h" 5 #include "chrome/browser/extensions/extension_service_unittest.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <set> 8 #include <set>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 1145 matching lines...) Expand 10 before | Expand all | Expand 10 after
1156 AddPattern(&expected_patterns, "https://*.google.com/*"); 1156 AddPattern(&expected_patterns, "https://*.google.com/*");
1157 const Extension* extension = loaded_[0]; 1157 const Extension* extension = loaded_[0];
1158 const extensions::UserScriptList& scripts = 1158 const extensions::UserScriptList& scripts =
1159 extensions::ContentScriptsInfo::GetContentScripts(extension); 1159 extensions::ContentScriptsInfo::GetContentScripts(extension);
1160 ASSERT_EQ(2u, scripts.size()); 1160 ASSERT_EQ(2u, scripts.size());
1161 EXPECT_EQ(expected_patterns, scripts[0].url_patterns()); 1161 EXPECT_EQ(expected_patterns, scripts[0].url_patterns());
1162 EXPECT_EQ(2u, scripts[0].js_scripts().size()); 1162 EXPECT_EQ(2u, scripts[0].js_scripts().size());
1163 ExtensionResource resource00(extension->id(), 1163 ExtensionResource resource00(extension->id(),
1164 scripts[0].js_scripts()[0].extension_root(), 1164 scripts[0].js_scripts()[0].extension_root(),
1165 scripts[0].js_scripts()[0].relative_path()); 1165 scripts[0].js_scripts()[0].relative_path());
1166 base::FilePath expected_path(extension->path().AppendASCII("script1.js")); 1166 base::FilePath expected_path =
1167 ASSERT_TRUE(file_util::AbsolutePath(&expected_path)); 1167 base::MakeAbsoluteFilePath(extension->path().AppendASCII("script1.js"));
1168 EXPECT_TRUE(resource00.ComparePathWithDefault(expected_path)); 1168 EXPECT_TRUE(resource00.ComparePathWithDefault(expected_path));
1169 ExtensionResource resource01(extension->id(), 1169 ExtensionResource resource01(extension->id(),
1170 scripts[0].js_scripts()[1].extension_root(), 1170 scripts[0].js_scripts()[1].extension_root(),
1171 scripts[0].js_scripts()[1].relative_path()); 1171 scripts[0].js_scripts()[1].relative_path());
1172 expected_path = extension->path().AppendASCII("script2.js"); 1172 expected_path =
1173 ASSERT_TRUE(file_util::AbsolutePath(&expected_path)); 1173 base::MakeAbsoluteFilePath(extension->path().AppendASCII("script2.js"));
1174 EXPECT_TRUE(resource01.ComparePathWithDefault(expected_path)); 1174 EXPECT_TRUE(resource01.ComparePathWithDefault(expected_path));
1175 EXPECT_TRUE(!extensions::PluginInfo::HasPlugins(extension)); 1175 EXPECT_TRUE(!extensions::PluginInfo::HasPlugins(extension));
1176 EXPECT_EQ(1u, scripts[1].url_patterns().patterns().size()); 1176 EXPECT_EQ(1u, scripts[1].url_patterns().patterns().size());
1177 EXPECT_EQ("http://*.news.com/*", 1177 EXPECT_EQ("http://*.news.com/*",
1178 scripts[1].url_patterns().begin()->GetAsString()); 1178 scripts[1].url_patterns().begin()->GetAsString());
1179 ExtensionResource resource10(extension->id(), 1179 ExtensionResource resource10(extension->id(),
1180 scripts[1].js_scripts()[0].extension_root(), 1180 scripts[1].js_scripts()[0].extension_root(),
1181 scripts[1].js_scripts()[0].relative_path()); 1181 scripts[1].js_scripts()[0].relative_path());
1182 expected_path = 1182 expected_path =
1183 extension->path().AppendASCII("js_files").AppendASCII("script3.js"); 1183 extension->path().AppendASCII("js_files").AppendASCII("script3.js");
1184 ASSERT_TRUE(file_util::AbsolutePath(&expected_path)); 1184 expected_path = base::MakeAbsoluteFilePath(expected_path);
1185 EXPECT_TRUE(resource10.ComparePathWithDefault(expected_path)); 1185 EXPECT_TRUE(resource10.ComparePathWithDefault(expected_path));
1186 1186
1187 expected_patterns.ClearPatterns(); 1187 expected_patterns.ClearPatterns();
1188 AddPattern(&expected_patterns, "http://*.google.com/*"); 1188 AddPattern(&expected_patterns, "http://*.google.com/*");
1189 AddPattern(&expected_patterns, "https://*.google.com/*"); 1189 AddPattern(&expected_patterns, "https://*.google.com/*");
1190 EXPECT_EQ(expected_patterns, 1190 EXPECT_EQ(expected_patterns,
1191 extension->GetActivePermissions()->explicit_hosts()); 1191 extension->GetActivePermissions()->explicit_hosts());
1192 1192
1193 EXPECT_EQ(std::string(good1), loaded_[1]->id()); 1193 EXPECT_EQ(std::string(good1), loaded_[1]->id());
1194 EXPECT_EQ(std::string("My extension 2"), loaded_[1]->name()); 1194 EXPECT_EQ(std::string("My extension 2"), loaded_[1]->name());
(...skipping 4706 matching lines...) Expand 10 before | Expand all | Expand 10 after
5901 EXPECT_FALSE(extensions::HasExternalInstallError(service_)); 5901 EXPECT_FALSE(extensions::HasExternalInstallError(service_));
5902 EXPECT_FALSE(service_->IsExtensionEnabled(good_crx)); 5902 EXPECT_FALSE(service_->IsExtensionEnabled(good_crx));
5903 EXPECT_TRUE(service_->IsExtensionEnabled(page_action)); 5903 EXPECT_TRUE(service_->IsExtensionEnabled(page_action));
5904 5904
5905 ExtensionPrefs* prefs = service_->extension_prefs(); 5905 ExtensionPrefs* prefs = service_->extension_prefs();
5906 EXPECT_NE(0, prefs->GetDisableReasons(good_crx) & 5906 EXPECT_NE(0, prefs->GetDisableReasons(good_crx) &
5907 Extension::DISABLE_SIDELOAD_WIPEOUT); 5907 Extension::DISABLE_SIDELOAD_WIPEOUT);
5908 EXPECT_EQ(0, prefs->GetDisableReasons(page_action) & 5908 EXPECT_EQ(0, prefs->GetDisableReasons(page_action) &
5909 Extension::DISABLE_SIDELOAD_WIPEOUT); 5909 Extension::DISABLE_SIDELOAD_WIPEOUT);
5910 } 5910 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698