Move path functions from file_util to FilePath object.

chrome/browser/platform_util_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/platform_util.h"
 
 #include <commdlg.h>
 #include <dwmapi.h>
 #include <shellapi.h>
 #include <shlobj.h>
@@ skipping 13 matching lines @@
 #include "googleurl/src/gurl.h"
 #include "ui/base/win/shell.h"
 #include "ui/gfx/native_widget_types.h"
 
 using content::BrowserThread;
 
 namespace {
 
 void ShowItemInFolderOnFileThread(const base::FilePath& full_path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
-  base::FilePath dir = full_path.DirName();
+  base::FilePath dir = full_path.DirName().AsEndingWithSeparator();
   // ParseDisplayName will fail if the directory is "C:", it must be "C:\\".
-  if (dir.value() == L"" || !file_util::EnsureEndsWithSeparator(&dir))
+  if (dir.empty())

[rvargas (doing something else), 2013/04/02 01:39:56]

The old code rejected empty paths while the new version continues.

We should probably make AsEndingWithSeparator fail for empty paths.

[brettw, 2013/04/08 23:40:20]

Good catch, I also added tests for this case.

     return;
 
   typedef HRESULT (WINAPI *SHOpenFolderAndSelectItemsFuncPtr)(
       PCIDLIST_ABSOLUTE pidl_Folder,
       UINT cidl,
       PCUITEMID_CHILD_ARRAY pidls,
       DWORD flags);
 
   static SHOpenFolderAndSelectItemsFuncPtr open_folder_and_select_itemsPtr =
     NULL;
@@ skipping 150 matching lines @@
   ::SetForegroundWindow(window);
 }
 
 bool IsVisible(gfx::NativeView view) {
   // MSVC complains if we don't include != 0.
   return ::IsWindowVisible(view) != 0;
 }
 #endif
 
 }  // namespace platform_util