Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 1319543004: Revert of Plugins: Remove Shadow DOM Plugin Placeholder (Closed)

Created:
5 years, 4 months ago by dstockwell
Modified:
5 years, 4 months ago
Reviewers:
kinuko, tommycli, jbroman, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Plugins: Remove Shadow DOM Plugin Placeholder (patchset #4 id:70001 of https://codereview.chromium.org/1314643002/ ) Reason for revert: Caused several blink layout and unit tests to fail: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/53104 unit tests failures: PluginPlaceholderImplTest.MessageIsShown PluginPlaceholderImplTest.NotCloseable PluginPlaceholderImplTest.MessageDoesNotRunScripts FrameLoaderClientImplTest.CreatePluginPlaceholderForwardsToWebFrameClient PluginPlaceholderImplTest.MessageDoesNotAcceptElements PluginPlaceholderImplTest.Closeable layout test unexpected_failures: fast/plugins/plugin-placeholder-structured.html fast/plugins/plugin-placeholder-close.html fast/dom/shadow/remove-shadowroot-from-document-and-destroy-crash.html fast/plugins/plugin-placeholder-inherit.html fast/plugins/plugin-placeholder-csp.html fast/plugins/plugin-placeholder-focus.html Original issue's description: > Plugins: Remove Shadow DOM Plugin Placeholder > > It's not under active development and doesn't support Plugin Power Saver. It's > overall a good approach, but unfortunately Shadow DOM doesn't have a good > mechanism to call into C++ at present. > > Plugins themselves will (hopefully) be obsolete by the time it does. > > BUG=524115 > > Committed: https://crrev.com/0c85f0c129bd64e6f3e5aabb659621d8cf65c690 > Cr-Commit-Position: refs/heads/master@{#345496} TBR=jbroman@chromium.org,sky@chromium.org,kinuko@chromium.org,tommycli@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=524115 Committed: https://crrev.com/95a85137cf4a9e74cce2f7ab90f46c2e57e41f62 Cr-Commit-Position: refs/heads/master@{#345524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -0 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client_browsertest.cc View 2 chunks +102 lines, -0 lines 0 comments Download
A chrome/renderer/plugins/shadow_dom_plugin_placeholder.h View 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/renderer/plugins/shadow_dom_plugin_placeholder.cc View 1 chunk +73 lines, -0 lines 0 comments Download
M components/html_viewer/blink_resource_constants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dstockwell
Created Revert of Plugins: Remove Shadow DOM Plugin Placeholder
5 years, 4 months ago (2015-08-26 01:34:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319543004/1
5 years, 4 months ago (2015-08-26 01:35:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-26 01:35:30 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 01:36:25 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95a85137cf4a9e74cce2f7ab90f46c2e57e41f62
Cr-Commit-Position: refs/heads/master@{#345524}

Powered by Google App Engine
This is Rietveld 408576698