Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1319543003: Example CMake build for Skia. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Example CMake build for Skia. This works only on Mac, probably only on 64-bit, and doesn't support SkCodec. BUG=skia:4269 Committed: https://skia.googlesource.com/skia/+/e0f06a47522b81d9d81485bfd5c8e3333211db5a

Patch Set 1 #

Patch Set 2 : Add doc. #

Patch Set 3 : clarify #

Patch Set 4 : ---- #

Patch Set 5 : add comments #

Patch Set 6 : missed one #

Patch Set 7 : Optional dependencies are optional. #

Patch Set 8 : ApplicationServices covers everything #

Patch Set 9 : Build Ganesh. #

Patch Set 10 : fmt #

Patch Set 11 : use Ganesh #

Patch Set 12 : note #

Patch Set 13 : prune a few testing files #

Patch Set 14 : isolate os-specific code in example.cpp #

Patch Set 15 : portable GL dependency #

Patch Set 16 : -framework ApplicationServices only on Macs #

Patch Set 17 : sort #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -0 lines) Patch
A cmake/.gitignore View 1 1 chunk +11 lines, -0 lines 0 comments Download
A cmake/CMakeLists.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +178 lines, -0 lines 2 comments Download
A cmake/README.md View 1 2 3 4 5 6 7 8 1 chunk +27 lines, -0 lines 0 comments Download
A cmake/example.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +91 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
mtklein_C
5 years, 3 months ago (2015-08-28 14:19:07 UTC) #2
mtklein_C
+Brian
5 years, 3 months ago (2015-08-28 17:42:36 UTC) #4
mtklein_C
+Hal
5 years, 3 months ago (2015-08-28 18:05:02 UTC) #6
bsalomon
lgtm
5 years, 3 months ago (2015-08-28 18:40:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319543003/290001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319543003/290001
5 years, 3 months ago (2015-08-28 18:45:46 UTC) #10
commit-bot: I haz the power
Committed patchset #17 (id:290001) as https://skia.googlesource.com/skia/+/e0f06a47522b81d9d81485bfd5c8e3333211db5a
5 years, 3 months ago (2015-08-28 18:51:10 UTC) #11
jcgregorio
https://codereview.chromium.org/1319543003/diff/290001/cmake/CMakeLists.txt File cmake/CMakeLists.txt (right): https://codereview.chromium.org/1319543003/diff/290001/cmake/CMakeLists.txt#newcode15 cmake/CMakeLists.txt:15: file (GLOB_RECURSE headers ${ARGV}) Doesn't ARGV also include the ...
5 years, 3 months ago (2015-08-30 13:25:24 UTC) #12
mtklein
5 years, 3 months ago (2015-08-30 14:19:09 UTC) #14
Message was sent while issue was closed. 
https://codereview.chromium.org/1319543003/diff/290001/cmake/CMakeLists.txt
File cmake/CMakeLists.txt (right):

https://codereview.chromium.org/1319543003/diff/290001/cmake/CMakeLists.txt#n...
cmake/CMakeLists.txt:15: file (GLOB_RECURSE headers ${ARGV})
On 2015/08/30 13:25:24, jcgregorio wrote:
> Doesn't ARGV also include the 'out' passed in as the first argument?

Hmm, reading the docs, it may be I was looking for ARGN here.

Powered by Google App Engine
This is Rietveld 408576698