Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1319523007: triage remaining async tests (Closed)

Created:
5 years, 3 months ago by Jennifer Messerly
Modified:
5 years, 3 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

triage remaining async tests one fix, two rejected statically R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/e93d48a8a96839ffc56ef7fd8890d9d710b1b7ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M test/browser/language_tests.js View 1 chunk +4 lines, -6 lines 0 comments Download
A + test/codegen/language/async_helper_lib.dart View 1 chunk +2 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
5 years, 3 months ago (2015-09-01 00:05:35 UTC) #3
Leaf
lgtm
5 years, 3 months ago (2015-09-01 00:47:29 UTC) #4
Jennifer Messerly
5 years, 3 months ago (2015-09-01 00:49:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
e93d48a8a96839ffc56ef7fd8890d9d710b1b7ea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698