Chromium Code Reviews

Issue 1319503002: Clean the blacklisted form if a user saves a password. (Closed)

Created:
5 years, 3 months ago by vasilii
Modified:
5 years, 3 months ago
Reviewers:
dvadym
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean the blacklisted form if a user saves a password. BUG=524386 Committed: https://crrev.com/f5f469bfa8fcb7ac176bbd33ad942d2d20f0cc0e Cr-Commit-Position: refs/heads/master@{#345344}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+17 lines, -8 lines)
M components/password_manager/core/browser/password_form_manager.cc View 1 chunk +9 lines, -8 lines 0 comments
M components/password_manager/core/browser/password_form_manager_unittest.cc View 2 chunks +8 lines, -0 lines 0 comments

Messages

Total messages: 7 (2 generated)
vasilii
Hi Vadym, please review.
5 years, 3 months ago (2015-08-25 15:11:37 UTC) #2
dvadym
On 2015/08/25 15:11:37, vasilii wrote: > Hi Vadym, > > please review. LGTM
5 years, 3 months ago (2015-08-25 16:17:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319503002/1
5 years, 3 months ago (2015-08-25 16:18:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-25 16:23:33 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 16:24:08 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f5f469bfa8fcb7ac176bbd33ad942d2d20f0cc0e
Cr-Commit-Position: refs/heads/master@{#345344}

Powered by Google App Engine