Introduce TabRestoreServiceClient and //chrome implementation.

Introduce TabRestoreServiceClient and //chrome implementation.

Core tab restore code from //chrome/browser/sessions is targeted for
componentization in order to cleanly integrate with iOS. To achieve this goal,
the code needs to be cleaned of //content and //chrome dependencies. This CL
introduces the TabRestoreServiceClient interface, which is an abstraction of
Profile for usage within the core tab restore code. It also adds initial usage
of this interface to eliminate knowledge of //chrome-level factories and the
//chrome-level SessionService from PersistentTabRestoreService. Finally, it
moves the //chrome-level static functions for creating a TabRestoreService out
of the classes to be componentized and into TabRestoreServiceFactory.

BUG=528883
Committed: https://crrev.com/56789fe3d6f16eb33bb949ef697baed8c5458df0
Cr-Commit-Position: refs/heads/master@{#348099}

[blundell, 2015-09-08 15:11:50]

blundell@chromium.org changed reviewers:
+ sky@chromium.org

[blundell, 2015-09-08 18:25:48]

BTW, after introducing LiveTab (or whatever better name we settle on), my plan
is to rename TabRestoreServiceDelegate to LiveTabContext to eliminate the
potential confusion between TabRestoreServiceClient and
TabRestoreServiceDelegate.

[sky, 2015-09-08 23:44:59]

https://codereview.chromium.org/1319473014/diff/60001/chrome/browser/sessions...
File chrome/browser/sessions/persistent_tab_restore_service.cc (right):

https://codereview.chromium.org/1319473014/diff/60001/chrome/browser/sessions...
chrome/browser/sessions/persistent_tab_restore_service.cc:120: explicit
Delegate(Profile* profile,
nit: remove explicit.

https://codereview.chromium.org/1319473014/diff/60001/chrome/browser/sessions...
File chrome/browser/sessions/tab_restore_service_factory.cc (right):

https://codereview.chromium.org/1319473014/diff/60001/chrome/browser/sessions...
chrome/browser/sessions/tab_restore_service_factory.cc:61: return new
InMemoryTabRestoreService(profile, NULL);
NULL->nullptr (you need to update a number of places).

https://codereview.chromium.org/1319473014/diff/60001/components/sessions/cor...
File components/sessions/core/tab_restore_service_client.h (right):

https://codereview.chromium.org/1319473014/diff/60001/components/sessions/cor...
components/sessions/core/tab_restore_service_client.h:27:
GotLastSessionCallback;
nit: GetLastSessionCallback.

https://codereview.chromium.org/1319473014/diff/60001/components/sessions/cor...
components/sessions/core/tab_restore_service_client.h:36: virtual int
GetMaxPersistNavigationCount() = 0;
Is there a reason this needs to be a function and not a constant supplied along
with the client? Or perhaps hard coded?

[blundell, 2015-09-09 10:27:10]

https://codereview.chromium.org/1319473014/diff/60001/chrome/browser/sessions...
File chrome/browser/sessions/persistent_tab_restore_service.cc (right):

https://codereview.chromium.org/1319473014/diff/60001/chrome/browser/sessions...
chrome/browser/sessions/persistent_tab_restore_service.cc:120: explicit
Delegate(Profile* profile,
On 2015/09/08 23:44:59, sky wrote:
> nit: remove explicit.

Done.

https://codereview.chromium.org/1319473014/diff/60001/chrome/browser/sessions...
File chrome/browser/sessions/tab_restore_service_factory.cc (right):

https://codereview.chromium.org/1319473014/diff/60001/chrome/browser/sessions...
chrome/browser/sessions/tab_restore_service_factory.cc:61: return new
InMemoryTabRestoreService(profile, NULL);
On 2015/09/08 23:44:59, sky wrote:
> NULL->nullptr (you need to update a number of places).

Done.

https://codereview.chromium.org/1319473014/diff/60001/components/sessions/cor...
File components/sessions/core/tab_restore_service_client.h (right):

https://codereview.chromium.org/1319473014/diff/60001/components/sessions/cor...
components/sessions/core/tab_restore_service_client.h:27:
GotLastSessionCallback;
On 2015/09/08 23:44:59, sky wrote:
> nit: GetLastSessionCallback.

Done.

https://codereview.chromium.org/1319473014/diff/60001/components/sessions/cor...
components/sessions/core/tab_restore_service_client.h:36: virtual int
GetMaxPersistNavigationCount() = 0;
On 2015/09/08 23:44:59, sky wrote:
> Is there a reason this needs to be a function and not a constant supplied
along
> with the client? Or perhaps hard coded?

Moved it into the component itself. At least at this time, this value doesn't
vary by embedder.

[sky, 2015-09-09 14:58:56]

LGTM

[blundell, 2015-09-10 05:06:30]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2015-09-10 05:06:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1319473014/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1319473014/80001

[commit-bot: I haz the power, 2015-09-10 05:11:24]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-10 05:12:18]

Patchset 5 (id:??) landed as
https://crrev.com/56789fe3d6f16eb33bb949ef697baed8c5458df0
Cr-Commit-Position: refs/heads/master@{#348099}

[commit-bot: I haz the power, 2015-09-23 12:07:40]

Patchset 5 (id:??) landed as
https://crrev.com/56789fe3d6f16eb33bb949ef697baed8c5458df0
Cr-Commit-Position: refs/heads/master@{#348099}