Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1319473007: Delete a bunch of NPAPI layout tests. (Closed)

Created:
5 years, 3 months ago by dcheng
Modified:
5 years, 3 months ago
Reviewers:
chrishtr
CC:
blink-reviews, Will Harris
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Delete a bunch of NPAPI layout tests. These layout tests deal with NPTypes and NPN_Functions. Any equivalents in PPAPI should already be covered by the existing Pepper browser tests. BUG=474535 R=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201724

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2744 lines) Patch
M LayoutTests/TestExpectations View 1 6 chunks +0 lines, -12 lines 0 comments Download
D LayoutTests/platform/linux/plugins/netscape-dom-access-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/plugins/netscape-dom-access-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/platform/mac/plugins/netscape-dom-access-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/plugins/netscape-dom-access-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/platform/win-xp/plugins/netscape-dom-access-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/plugins/netscape-dom-access-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/win/plugins/netscape-dom-access-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/plugins/netscape-dom-access-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/plugins/attach-during-destroy.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/plugins/attach-during-destroy-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/plugins/call-as-function.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/plugins/call-as-function-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/plugins/destroy-during-npp-new.html View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/plugins/destroy-during-npp-new-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/plugins/destroy-during-npp-new-object-with-fallback-content.html View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/plugins/destroy-during-npp-new-object-with-fallback-content-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/plugins/destroy-on-setwindow.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/plugins/destroy-on-setwindow-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/plugins/destroy-reentry.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/plugins/destroy-reentry-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/plugins/destroy-stream-twice.html View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/plugins/destroy-stream-twice-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/plugins/get-empty-url.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/plugins/get-empty-url-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/plugins/get-file-url.html View 1 chunk +0 lines, -41 lines 0 comments Download
D LayoutTests/plugins/get-file-url-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/plugins/get-javascript-url.html View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/plugins/get-javascript-url-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/plugins/get-targeted-javascript-url.html View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/plugins/get-targeted-javascript-url-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/plugins/get-url-notify-with-url-that-fails-to-load.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/plugins/get-url-notify-with-url-that-fails-to-load-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/plugins/get-url-that-the-resource-load-delegate-will-disallow.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/plugins/get-url-that-the-resource-load-delegate-will-disallow-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/plugins/get-url-with-iframe-target.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/plugins/get-url-with-iframe-target-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/plugins/get-url-with-javascript-destroying-plugin.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/plugins/get-url-with-javascript-destroying-plugin-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/plugins/get-url-with-javascript-url.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/plugins/get-url-with-javascript-url-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/plugins/get-user-agent-with-null-npp-from-npp-new.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/plugins/get-user-agent-with-null-npp-from-npp-new-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/plugins/geturl-replace-query.html View 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/plugins/geturl-replace-query-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/plugins/geturlnotify-during-document-teardown.html View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/plugins/geturlnotify-during-document-teardown-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/plugins/js-from-destroy.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/plugins/js-from-destroy-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/plugins/netscape-destroy-plugin-script-objects.html View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/plugins/netscape-destroy-plugin-script-objects-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/plugins/netscape-dom-access.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/plugins/netscape-dom-access-and-reload.html View 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/plugins/netscape-dom-access-and-reload-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/plugins/netscape-plugin-property-access-exception.html View 1 chunk +0 lines, -71 lines 0 comments Download
D LayoutTests/plugins/netscape-plugin-property-access-exception-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/plugins/netscape-plugin-setwindow-size.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/plugins/netscape-plugin-setwindow-size-2.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/plugins/netscape-plugin-setwindow-size-2-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/plugins/netscape-plugin-setwindow-size-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/plugins/npobject-js-wrapper-destroyed-after-plugin-unload.html View 1 chunk +0 lines, -51 lines 0 comments Download
D LayoutTests/plugins/npobject-js-wrapper-destroyed-after-plugin-unload-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/plugins/npp-new-fails.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/plugins/npp-new-fails-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/plugins/npp-set-window-called-during-destruction.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/plugins/npp-set-window-called-during-destruction-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/plugins/npruntime/browser-object-identity.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/plugins/npruntime/browser-object-identity-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/plugins/npruntime/construct.html View 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/plugins/npruntime/construct-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/plugins/npruntime/delete-plugin-within-getProperty.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/plugins/npruntime/delete-plugin-within-getProperty-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/plugins/npruntime/delete-plugin-within-hasProperty-return-false.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/plugins/npruntime/delete-plugin-within-hasProperty-return-false-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/plugins/npruntime/delete-plugin-within-hasProperty-return-true.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/plugins/npruntime/delete-plugin-within-hasProperty-return-true-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/plugins/npruntime/delete-plugin-within-invoke.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/plugins/npruntime/delete-plugin-within-invoke-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/plugins/npruntime/delete-plugin-within-setProperty.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/plugins/npruntime/delete-plugin-within-setProperty-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/plugins/npruntime/embed-property.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/plugins/npruntime/embed-property-equality.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/plugins/npruntime/embed-property-equality-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/plugins/npruntime/embed-property-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/plugins/npruntime/embed-property-iframe-equality.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/plugins/npruntime/embed-property-iframe-equality-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/plugins/npruntime/enumerate.html View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/plugins/npruntime/enumerate-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/plugins/npruntime/evaluate.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/plugins/npruntime/evaluate-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/plugins/npruntime/get-int-identifier-special-values.html View 1 chunk +0 lines, -61 lines 0 comments Download
D LayoutTests/plugins/npruntime/get-int-identifier-special-values-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/plugins/npruntime/get-property-return-value.html View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/plugins/npruntime/get-property-return-value-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/plugins/npruntime/identifier-conversion.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/plugins/npruntime/identifier-conversion-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/plugins/npruntime/invoke.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/plugins/npruntime/invoke-browserfuncs.html View 1 chunk +0 lines, -52 lines 0 comments Download
D LayoutTests/plugins/npruntime/invoke-browserfuncs-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/plugins/npruntime/invoke-default.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/plugins/npruntime/invoke-default-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/plugins/npruntime/invoke-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/plugins/npruntime/invoke-failure.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/plugins/npruntime/invoke-failure-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/plugins/npruntime/leak-window-scriptable-object.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/plugins/npruntime/leak-window-scriptable-object-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/plugins/npruntime/np-deallocate-called-before-np-shutdown.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/plugins/npruntime/np-deallocate-called-before-np-shutdown-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/plugins/npruntime/npruntime.html View 1 chunk +0 lines, -60 lines 0 comments Download
D LayoutTests/plugins/npruntime/npruntime-calls-with-null-npp.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/plugins/npruntime/npruntime-calls-with-null-npp-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/plugins/npruntime/npruntime-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/plugins/npruntime/object-from-destroyed-plugin.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/plugins/npruntime/object-from-destroyed-plugin-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/plugins/npruntime/object-from-destroyed-plugin-in-subframe.html View 1 chunk +0 lines, -35 lines 0 comments Download
D LayoutTests/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/plugins/npruntime/plugin-scriptable-object-invoke-default.html View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/plugins/npruntime/plugin-scriptable-object-invoke-default-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/plugins/npruntime/remove-property.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/plugins/npruntime/remove-property-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/plugins/npruntime/round-trip-npobject.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/plugins/npruntime/round-trip-npobject-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/plugins/npruntime/script-tests/TEMPLATE.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/plugins/npruntime/script-tests/browser-object-identity.js View 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/plugins/npruntime/script-tests/identifier-conversion.js View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/plugins/npruntime/set-property.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/plugins/npruntime/set-property-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/plugins/npruntime/throw-exception.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/plugins/npruntime/throw-exception-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/plugins/null-npp-getvalue-pointer.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/plugins/null-npp-getvalue-pointer-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/plugins/object-embed-plugin-scripting.html View 1 chunk +0 lines, -139 lines 0 comments Download
D LayoutTests/plugins/object-embed-plugin-scripting-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/plugins/pass-different-npp-struct.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/plugins/pass-different-npp-struct-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/plugins/resize-from-plugin.html View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/plugins/resize-from-plugin-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/plugins/resources/get-file-url-subframe.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/plugins/resources/geturlnotify-on-destroy.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/plugins/resources/js-from-destroy-frame.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/plugins/resources/resize-from-plugin-frame.html View 1 chunk +0 lines, -41 lines 0 comments Download
D LayoutTests/plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/plugins/return-error-from-new-stream-callback-in-full-frame-plugin-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/plugins/return-error-from-new-stream-doesnt-invoke-destroy-stream.html View 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/plugins/return-error-from-new-stream-doesnt-invoke-destroy-stream-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/plugins/return-negative-one-from-write.html View 1 chunk +0 lines, -57 lines 0 comments Download
D LayoutTests/plugins/return-negative-one-from-write-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/plugins/return-npobject.html View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/plugins/return-npobject-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/plugins/script-object-invoke.html View 1 chunk +0 lines, -59 lines 0 comments Download
D LayoutTests/plugins/script-object-invoke-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/plugins/snapshot-appearance.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/plugins/snapshot-appearance-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
And if the PPAPI equivalents aren't already tested... that's too bad, because that means they ...
5 years, 3 months ago (2015-09-02 22:43:18 UTC) #2
dcheng
(oops, publishing drafts) https://codereview.chromium.org/1319473007/diff/1/LayoutTests/plugins/snapshot-appearance.html File LayoutTests/plugins/snapshot-appearance.html (left): https://codereview.chromium.org/1319473007/diff/1/LayoutTests/plugins/snapshot-appearance.html#oldcode10 LayoutTests/plugins/snapshot-appearance.html:10: -webkit-appearance: snapshotted-plugin-overlay; Actually, this test doesn't ...
5 years, 3 months ago (2015-09-02 22:44:10 UTC) #3
chrishtr
lgtm
5 years, 3 months ago (2015-09-03 16:18:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319473007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319473007/1
5 years, 3 months ago (2015-09-03 16:18:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/96177)
5 years, 3 months ago (2015-09-03 16:28:31 UTC) #8
dcheng
5 years, 3 months ago (2015-09-03 16:36:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 201724 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698