Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: skia/ext/skia_memory_dump_provider_unittest.cc

Issue 1319473003: [tracing] Add SkResourceCache statistics to chrome://tracing (chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@discardable_objdumps
Patch Set: Mac build fix. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/ext/skia_memory_dump_provider.cc ('k') | skia/skia_chrome.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/ext/skia_memory_dump_provider_unittest.cc
diff --git a/skia/ext/skia_memory_dump_provider_unittest.cc b/skia/ext/skia_memory_dump_provider_unittest.cc
index 3432f18fb5a2cbc527c051c683197f51676edf9c..915323b6a3ea158328927e2623d1447858d49778 100644
--- a/skia/ext/skia_memory_dump_provider_unittest.cc
+++ b/skia/ext/skia_memory_dump_provider_unittest.cc
@@ -8,6 +8,7 @@
namespace skia {
+// Tests if the skia dump provider dumps without crashing.
TEST(SkiaMemoryDumpProviderTest, OnMemoryDump) {
scoped_ptr<base::trace_event::ProcessMemoryDump> process_memory_dump(
new base::trace_event::ProcessMemoryDump(nullptr));
@@ -16,8 +17,7 @@ TEST(SkiaMemoryDumpProviderTest, OnMemoryDump) {
SkiaMemoryDumpProvider::GetInstance()->OnMemoryDump(
dump_args, process_memory_dump.get());
- ASSERT_TRUE(process_memory_dump->GetAllocatorDump("skia/sk_font_cache"));
- ASSERT_TRUE(process_memory_dump->GetAllocatorDump("skia/sk_resource_cache"));
+ ASSERT_TRUE(process_memory_dump->GetAllocatorDump("skia/sk_glyph_cache"));
}
} // namespace skia
« no previous file with comments | « skia/ext/skia_memory_dump_provider.cc ('k') | skia/skia_chrome.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698