Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: skia/ext/SkTraceMemoryDump_chrome.h

Issue 1319473003: [tracing] Add SkResourceCache statistics to chrome://tracing (chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@discardable_objdumps
Patch Set: Adding DCHECK. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef SKIA_EXT_SK_TRACE_MEMORY_DUMP_CHROME_H_
6 #define SKIA_EXT_SK_TRACE_MEMORY_DUMP_CHROME_H_
7
8 #include "base/macros.h"
9 #include "third_party/skia/include/core/SkTraceMemoryDump.h"
10
11 namespace base {
12 namespace trace_event {
13 class ProcessMemoryDump;
14 }
15 }
16
17 namespace skia {
18
19 class SkTraceMemoryDump_Chrome : public SkTraceMemoryDump {
20 public:
Primiano Tucci (use gerrit) 2015/08/26 15:34:01 I'd add a comment to this class specifying that th
ssid 2015/08/26 15:45:19 Done.
21 SkTraceMemoryDump_Chrome(
22 base::trace_event::ProcessMemoryDump* process_memory_dump);
23 ~SkTraceMemoryDump_Chrome() override;
Primiano Tucci (use gerrit) 2015/08/26 15:34:01 just to doublecheck, i think that (probably in a f
ssid 2015/08/26 15:45:19 Yes constructor and setMemoryBacking will be chang
ericrk 2015/08/26 18:12:06 Yeah, will likely need this... that said, I think
24
25 // SkTraceMemoryDump implementation:
26 void dumpNumericValue(const char* dumpName,
27 const char* valueName,
28 const char* units,
29 uint64_t value) override;
30 void setMemoryBacking(const char* dumpName,
31 const char* backingType,
32 const char* backingObjectId) override;
33 void setDiscardableMemoryBacking(
34 const char* dumpName,
35 const SkDiscardableMemory& discardableMemoryObject) override;
36
37 private:
38 base::trace_event::ProcessMemoryDump* process_memory_dump_;
39
40 DISALLOW_COPY_AND_ASSIGN(SkTraceMemoryDump_Chrome);
41 };
42
43 } // namespace skia
44
45 #endif // SKIA_EXT_SK_TRACE_MEMORY_DUMP_CHROME_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698