Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1319463003: Do not attempt to read language mode from {,Strict}{,Not}Equal nodes. (Closed)

Created:
5 years, 3 months ago by pcc1
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not attempt to read language mode from {,Strict}{,Not}Equal nodes. We were previously reading a language mode from all comparison nodes in JSGenericLowering::ReplaceWithCompareIC. This read was invalid for {,Strict}{,Not}Equal nodes, as these nodes do not have a language mode, as they derive from Operator rather than from Operator1<LanguageMode>. Because these nodes are not language mode dependent, we arbitrarily pass Strength::WEAK to CodeFactory::CompareIC. Cleanup for cfi_vptr=1; see https://www.chromium.org/developers/testing/control-flow-integrity BUG=chromium:457523 R=bmeurer@chromium.org LOG=N Committed: https://crrev.com/09bb401b803eef0f2c6afa104d8ff80d821d9d61 Cr-Commit-Position: refs/heads/master@{#30491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M src/compiler/js-generic-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +20 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
pcc1
5 years, 3 months ago (2015-09-01 03:59:25 UTC) #1
Benedikt Meurer
LGTM
5 years, 3 months ago (2015-09-01 04:04:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319463003/1
5 years, 3 months ago (2015-09-01 04:16:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 04:41:33 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 04:41:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09bb401b803eef0f2c6afa104d8ff80d821d9d61
Cr-Commit-Position: refs/heads/master@{#30491}

Powered by Google App Engine
This is Rietveld 408576698