gpu/command_buffer/common/gles2_cmd_utils.cc - Issue 1319453010: Fix GetFramebufferAttachmentParameteriv command handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/common/gles2_cmd_utils.cc

Issue 1319453010: Fix GetFramebufferAttachmentParameteriv command handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix gpu_unittests and gl_tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/build_gles2_cmd_buffer.py ('k') | gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/common/gles2_cmd_utils.cc

diff --git a/gpu/command_buffer/common/gles2_cmd_utils.cc b/gpu/command_buffer/common/gles2_cmd_utils.cc

index e30e2e38c74705a99d7b14f1f8acabaa8a0aac26..063a37e2b6567701754864475ccfee3108509d3c 100644

--- a/gpu/command_buffer/common/gles2_cmd_utils.cc

+++ b/gpu/command_buffer/common/gles2_cmd_utils.cc

@@ -262,6 +262,23 @@ int GLES2Util::GLGetNumValuesReturned(int id) const {

// GL_EXT_sRGB

case GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING_EXT:

return 1;

+ // ES3

+ case GL_FRAMEBUFFER_ATTACHMENT_RED_SIZE:

+ return 1;

+ case GL_FRAMEBUFFER_ATTACHMENT_GREEN_SIZE:

+ return 1;

+ case GL_FRAMEBUFFER_ATTACHMENT_BLUE_SIZE:

+ return 1;

+ case GL_FRAMEBUFFER_ATTACHMENT_ALPHA_SIZE:

+ return 1;

+ case GL_FRAMEBUFFER_ATTACHMENT_DEPTH_SIZE:

+ return 1;

+ case GL_FRAMEBUFFER_ATTACHMENT_STENCIL_SIZE:

+ return 1;

+ case GL_FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE:

+ return 1;

+ case GL_FRAMEBUFFER_ATTACHMENT_TEXTURE_LAYER:

+ return 1;

// -- glGetProgramiv

case GL_DELETE_STATUS: