Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1544)

Issue 1319453003: Add KHR_blend_equation_advanced (Closed)

Created:
5 years, 3 months ago by jamesr
Modified:
5 years, 3 months ago
Reviewers:
viettrungluu
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -2 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/gles2/gles2_impl.cc View 1 chunk +1 line, -0 lines 1 comment Download
M mojo/gpu/mojo_gles2_impl_autogen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/platform/native/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + mojo/public/platform/native/gles2/call_visitor_khr_blend_equation_advanced_autogen.h View 1 chunk +1 line, -1 line 0 comments Download
A mojo/public/platform/native/gles2_impl_khr_blend_equation_advanced_thunks.h View 1 chunk +54 lines, -0 lines 0 comments Download
A mojo/public/platform/native/gles2_impl_khr_blend_equation_advanced_thunks.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M shell/native_application_support.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jamesr
5 years, 3 months ago (2015-08-27 16:51:55 UTC) #2
jamesr
https://codereview.chromium.org/1319453003/diff/1/mojo/gles2/gles2_impl.cc File mojo/gles2/gles2_impl.cc (right): https://codereview.chromium.org/1319453003/diff/1/mojo/gles2/gles2_impl.cc#newcode66 mojo/gles2/gles2_impl.cc:66: #include "mojo/public/platform/native/gles2/call_visitor_khr_blend_equation_advanced_autogen.h" aside: it would be somewhat nice to ...
5 years, 3 months ago (2015-08-27 16:52:23 UTC) #3
viettrungluu
lgtm
5 years, 3 months ago (2015-08-27 17:54:29 UTC) #4
jamesr
5 years, 3 months ago (2015-08-27 19:29:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3f90f82589fb92f4a3b89862fd6ef8ab3699c5ac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698