Source/core/css/CSSPrimitiveValue.h - Issue 1319453002: Experiment: Switch to code-driven conversion of CSS unit type names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSPrimitiveValue.h

Issue 1319453002: Experiment: Switch to code-driven conversion of CSS unit type names. Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: drop redundant namespace prefix Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSPrimitiveValue.h

diff --git a/Source/core/css/CSSPrimitiveValue.h b/Source/core/css/CSSPrimitiveValue.h

index a32af7d5237b5bc9da538abade86e91370a3efa3..96b925244d9766a6fe229369682489ff8c8cb330 100644

--- a/Source/core/css/CSSPrimitiveValue.h

+++ b/Source/core/css/CSSPrimitiveValue.h

@@ -156,9 +156,8 @@ public:

static UnitCategory unitCategory(UnitType);

static float clampToCSSLengthRange(double);

- static void initUnitTable();

- static UnitType fromName(const String& unit);

+ static UnitType fromName(const UChar* unit, unsigned length);

+ static UnitType fromName(const LChar* unit, unsigned length);

bool isAngle() const

{

« no previous file with comments | « Source/core/Init.cpp ('k') | Source/core/css/CSSPrimitiveValue.cpp » ('j') | no next file with comments »