Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1319433003: Don't change the media controls visibility in MediaControls::reset() (Closed)

Created:
5 years, 4 months ago by philipj_slow
Modified:
5 years, 4 months ago
Reviewers:
fs
CC:
blink-reviews, nessy, mlamouri+watch-blink_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't change the media controls visibility in MediaControls::reset() reset() is called from a number of places with the expectation of putting the controls into the state they would be if created anew. One such place is via HTMLMediaElement::preDispatchEventHandler, where the controls are reset when entering or exiting fullscreen. This has a very strange side-effect, namely that dispatching a synthetic webkitfullscreenchange event on a video will cause the media controls to become visible. It would be rather messy to write a layout test for this, and it would be slow to run, so instead add unit tests to test this more directly. R=fs@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -2 lines) Patch
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/shadow/MediaControls.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 1 chunk +0 lines, -1 line 0 comments Download
A Source/core/html/shadow/MediaControlsTest.cpp View 1 chunk +106 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
philipj_slow
5 years, 4 months ago (2015-08-25 09:10:13 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319433003/1
5 years, 4 months ago (2015-08-25 09:10:37 UTC) #3
fs
lgtm
5 years, 4 months ago (2015-08-25 09:18:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-25 10:23:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319433003/1
5 years, 4 months ago (2015-08-25 11:23:49 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 11:28:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201126

Powered by Google App Engine
This is Rietveld 408576698