DescriptionDon't change the media controls visibility in MediaControls::reset()
reset() is called from a number of places with the expectation of
putting the controls into the state they would be if created anew.
One such place is via HTMLMediaElement::preDispatchEventHandler, where
the controls are reset when entering or exiting fullscreen. This has a
very strange side-effect, namely that dispatching a synthetic
webkitfullscreenchange event on a video will cause the media controls to
become visible.
It would be rather messy to write a layout test for this, and it would
be slow to run, so instead add unit tests to test this more directly.
R=fs@opera.com
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201126
Patch Set 1 #
Messages
Total messages: 9 (3 generated)
|