Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 1319393003: Adds components/web_view to list of files to run gn check over (Closed)

Created:
5 years, 3 months ago by sky
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds components/web_view to list of files to run gn check over BUG=521186 TEST=none R=ben@chromium.org TBR=ben@chromium.org Committed: https://crrev.com/919ca822eb1feb888f083bf33d56ed25953886f5 Cr-Commit-Position: refs/heads/master@{#347290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
5 years, 3 months ago (2015-09-03 23:04:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319393003/1
5 years, 3 months ago (2015-09-03 23:04:46 UTC) #3
Ben Goodger (Google)
lgtm
5 years, 3 months ago (2015-09-03 23:04:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 23:55:24 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 23:56:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/919ca822eb1feb888f083bf33d56ed25953886f5
Cr-Commit-Position: refs/heads/master@{#347290}

Powered by Google App Engine
This is Rietveld 408576698