Source/core/css/parser/CSSParserValues.cpp - Issue 1319343004: Add property parser code path based on CSSParserTokenRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSParserValues.cpp

Issue 1319343004: Add property parser code path based on CSSParserTokenRange (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Move driver code Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/css/parser/CSSParserToken.cpp ('k') | Source/core/css/parser/CSSPropertyParser.h » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/CSSParserValues.cpp

diff --git a/Source/core/css/parser/CSSParserValues.cpp b/Source/core/css/parser/CSSParserValues.cpp

index 5d32628616b5b423a5bce110ba015e44fb063a5a..ec23f0e13357c0b31ffa0838c60642d0f79bafa2 100644

--- a/Source/core/css/parser/CSSParserValues.cpp

+++ b/Source/core/css/parser/CSSParserValues.cpp

@@ -65,7 +65,7 @@ CSSParserValueList::CSSParserValueList(CSSParserTokenRange range)

value.id = CSSValueInvalid;

value.isInt = false;

- CSSValueID id = cssValueKeywordID(token.value());

+ CSSValueID id = token.functionId();

if (id == CSSValueCalc || id == CSSValueWebkitCalc) {

value.m_unit = CSSParserValue::CalcFunction;

value.calcFunction = new CSSParserCalcFunction(range.consumeBlock());

@@ -108,7 +108,7 @@ CSSParserValueList::CSSParserValueList(CSSParserTokenRange range)

break;

}

case IdentToken: {

- value.id = cssValueKeywordID(token.value());

+ value.id = token.id();

value.isInt = false;

value.m_unit = CSSParserValue::Identifier;

value.string = token.value();

« no previous file with comments | « Source/core/css/parser/CSSParserToken.cpp ('k') | Source/core/css/parser/CSSPropertyParser.h » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')