Issue 131933003: [Mac] Make initial visibility of the promote button on the about page deterministic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131933003: [Mac] Make initial visibility of the promote button on the about page deterministic (Closed)

Created:
6 years, 11 months ago by Mark Mentovai

Modified:
6 years, 11 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Mac] Make initial visibility of the promote button on the about page deterministic. An uninitialized member variable was at fault. R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244260

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/ui/webui/help/version_updater_mac.mm	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Mark Mentovai

Broken out from https://codereview.chromium.org/125443002/ because that change is held up waiting for things beyond my ...

6 years, 11 months ago (2014-01-10 21:30:25 UTC) #1

Mark Mentovai

6 years, 11 months ago (2014-01-10 22:05:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r244260 (presubmit successful).