Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: lib/src/utils.dart

Issue 1319303004: Optimize successive calls SourceFile.getLine(). (Closed) Base URL: https://github.com/dart-lang/source_span.git@master
Patch Set: Add boundary case checking back in and remove tests for old binary search. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/src/location.dart ('k') | pubspec.yaml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library source_span.utils; 5 library source_span.utils;
6 6
7 /// Returns the minimum of [obj1] and [obj2] according to 7 /// Returns the minimum of [obj1] and [obj2] according to
8 /// [Comparable.compareTo]. 8 /// [Comparable.compareTo].
9 Comparable min(Comparable obj1, Comparable obj2) => 9 Comparable min(Comparable obj1, Comparable obj2) =>
10 obj1.compareTo(obj2) > 0 ? obj2 : obj1; 10 obj1.compareTo(obj2) > 0 ? obj2 : obj1;
11 11
12 /// Returns the maximum of [obj1] and [obj2] according to 12 /// Returns the maximum of [obj1] and [obj2] according to
13 /// [Comparable.compareTo]. 13 /// [Comparable.compareTo].
14 Comparable max(Comparable obj1, Comparable obj2) => 14 Comparable max(Comparable obj1, Comparable obj2) =>
15 obj1.compareTo(obj2) > 0 ? obj1 : obj2; 15 obj1.compareTo(obj2) > 0 ? obj1 : obj2;
16 16
17 /// Find the first entry in a sorted [list] that matches a monotonic predicate.
18 ///
19 /// Given a result `n`, that all items before `n` will not match, `n` matches,
20 /// and all items after `n` match too. The result is -1 when there are no
21 /// items, 0 when all items match, and list.length when none does.
22 int binarySearch(List list, bool matches(item)) {
23 if (list.length == 0) return -1;
24 if (matches(list.first)) return 0;
25 if (!matches(list.last)) return list.length;
26
27 int min = 0;
28 int max = list.length - 1;
29 while (min < max) {
30 var half = min + ((max - min) ~/ 2);
31 if (matches(list[half])) {
32 max = half;
33 } else {
34 min = half + 1;
35 }
36 }
37 return max;
38 }
39
40 /// Finds a line in [context] containing [text] at the specified [column]. 17 /// Finds a line in [context] containing [text] at the specified [column].
41 /// 18 ///
42 /// Returns the index in [context] where that line begins, or null if none 19 /// Returns the index in [context] where that line begins, or null if none
43 /// exists. 20 /// exists.
44 int findLineStart(String context, String text, int column) { 21 int findLineStart(String context, String text, int column) {
45 var isEmpty = text == ''; 22 var isEmpty = text == '';
46 var index = context.indexOf(text); 23 var index = context.indexOf(text);
47 while (index != -1) { 24 while (index != -1) {
48 var lineStart = context.lastIndexOf('\n', index) + 1; 25 var lineStart = context.lastIndexOf('\n', index) + 1;
49 var textColumn = index - lineStart; 26 var textColumn = index - lineStart;
50 if (column == textColumn || (isEmpty && column == textColumn + 1)) { 27 if (column == textColumn || (isEmpty && column == textColumn + 1)) {
51 return lineStart; 28 return lineStart;
52 } 29 }
53 index = context.indexOf(text, index + 1); 30 index = context.indexOf(text, index + 1);
54 } 31 }
55 return null; 32 return null;
56 } 33 }
OLDNEW
« no previous file with comments | « lib/src/location.dart ('k') | pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698