Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1319213004: Update bookmark bar folder icons to MD; vectorize. (Closed)

Created:
5 years, 3 months ago by Evan Stade
Modified:
5 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update bookmark bar folder icons to MD; vectorize. IDR_BOOKMARK_BAR_FOLDER is not yet deleted because it's still used in chrome://bookmarks. BUG=505953 Committed: https://crrev.com/14415067eb5131fd93aa1096b42e2a38c97b6657 Cr-Commit-Position: refs/heads/master@{#346733}

Patch Set 1 #

Patch Set 2 : android build #

Patch Set 3 : fix bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -35 lines) Patch
D chrome/app/theme/default_100_percent/common/bookmark_bar_folder_managed.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/bookmark_bar_folder_supervised.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/bookmark_bar_folder_managed.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/bookmark_bar_folder_supervised.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_utils.h View 1 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_utils.cc View 1 2 3 chunks +30 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 5 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 4 chunks +16 lines, -19 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/folder.icon View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/folder_managed.icon View 1 2 1 chunk +81 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/folder_supervised.icon View 1 2 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
This doesn't look so great on the bm bar on a dark theme, but then ...
5 years, 3 months ago (2015-09-01 19:10:50 UTC) #2
sky
LGTM
5 years, 3 months ago (2015-09-01 20:36:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319213004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319213004/40001
5 years, 3 months ago (2015-09-01 20:41:37 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-01 20:58:44 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 20:59:25 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/14415067eb5131fd93aa1096b42e2a38c97b6657
Cr-Commit-Position: refs/heads/master@{#346733}

Powered by Google App Engine
This is Rietveld 408576698